We have now gone in a circle.

But it should work now because of the updated vcpkg version

Author: zpostfacto

.github/setup-msvc-env.bat

@@ -62,48 +62,37 @@ jobs:
         run: git config --global --add safe.directory '*'
         shell: cmd
 
+      # Setup MSVC command prompt environment vars.
+      # We must do this before sedtting up our local vcpkg,
+      # Because it will set VCPKG_ROOT to point to some global
+      # install of vcpkg, and we don't want that
+      - uses: ilammy/msvc-dev-cmd@v1
+
       - name: vcpkg check / install dependencies
         working-directory: '${{ github.workspace }}'
-        run: |
-          call %GITHUB_WORKSPACE%\.github\setup-msvc-env.bat
-          "${{env.VCPKG_ROOT}}\vcpkg" install --triplet=x64-windows
+        run: '"${{env.VCPKG_ROOT}}\vcpkg" install --triplet=x64-windows'
         shell: cmd
 
       - name: Install dependencies and generate project files
         run: |
-          call %GITHUB_WORKSPACE%\.github\setup-msvc-env.bat
-          echo ==== Compiler diagnostics before configure ====
-          where cl || echo cl not found on PATH
-          where cc || echo cc not found on PATH
-          where c++.exe || echo c++.exe not found on PATH
-          echo CC=%CC%
-          echo CXX=%CXX%
           mkdir build
           cd build
           cmake -S .. -G Ninja -DCMAKE_C_COMPILER=cl -DCMAKE_CXX_COMPILER=cl -DBUILD_TESTS=ON -DBUILD_EXAMPLES=ON -DBUILD_TOOLS=ON -DCMAKE_TOOLCHAIN_FILE=${{env.VCPKG_ROOT}}/scripts/buildsystems/vcpkg.cmake -DUSE_CRYPTO=${{matrix.crypto}}
-          echo ==== CMake compiler cache ====
-          findstr /R "^CMAKE_C_COMPILER:.*" CMakeCache.txt
-          findstr /R "^CMAKE_CXX_COMPILER:.*" CMakeCache.txt
         shell: cmd
 
       - name: Build projects
         working-directory: '${{ github.workspace }}/build'
-        run: |
-          call %GITHUB_WORKSPACE%\.github\setup-msvc-env.bat
-          ninja
+        run: ninja
         shell: cmd
 
       - name: Test crypto
         working-directory: '${{ github.workspace }}/build/bin'
-        run: |
-          call %GITHUB_WORKSPACE%\.github\setup-msvc-env.bat
-          test_crypto.exe
+        run: test_crypto.exe
         shell: cmd
 
       - name: Test connection
         working-directory: '${{ github.workspace }}/build/bin'
         run: |
-          call %GITHUB_WORKSPACE%\.github\setup-msvc-env.bat
           rem test_connection.exe suite-quick  -- Loopback throughput test not performing on github hosted runners for some reason
           test_connection.exe identity quick lane_quick_queueanddrain lane_quick_priority_and_background
         shell: cmd