trivial signaling server: move fault injection

Our protocol isn't tolerant of all types of failures, and we aren't
really interested in testing them.  Only drop/dup the actual signals.

Author: zpostfacto

examples/trivial_signaling_client.cpp

@@ -97,7 +97,17 @@ class CTrivialSignalingClient : public ITrivialSignalingClient
 			}
 			signal.push_back('\n');
 
+			// Simulate an unreliable signaling channel.  Applied here rather than
+			// in Send() so that only ICE signals are affected, not the connection
+			// management greeting.
+			if ( m_pOwner->m_nLossPct > 0 && ( rand() % 100 ) < m_pOwner->m_nLossPct )
+				return true;
+
 			m_pOwner->Send( signal );
+
+			if ( m_pOwner->m_nDupPct > 0 && ( rand() % 100 ) < m_pOwner->m_nDupPct )
+				m_pOwner->Send( signal );
+
 			return true;
 		}
 
@@ -182,15 +192,12 @@ class CTrivialSignalingClient : public ITrivialSignalingClient
 		Connect();
 	}
 
-	// Send the signal.
+	// Send a raw line to the signaling server.  No fault injection here;
+	// fault injection for ICE signals lives in ConnectionSignaling::SendSignal.
 	void Send( const std::string &s )
 	{
 		assert( s.length() > 0 && s[ s.length()-1 ] == '\n' ); // All of our signals are '\n'-terminated
 
-		// Simulate unreliable signaling channel: randomly drop signals.
-		if ( m_nLossPct > 0 && ( rand() % 100 ) < m_nLossPct )
-			return;
-
 		sockMutex.lock();
 
 		// If we're getting backed up, delete the oldest entries.  Remember,
@@ -204,11 +211,6 @@ class CTrivialSignalingClient : public ITrivialSignalingClient
 		}
 
 		m_queueSend.push_back( s );
-
-		// Simulate duplicate delivery.
-		if ( m_nDupPct > 0 && ( rand() % 100 ) < m_nDupPct )
-			m_queueSend.push_back( s );
-
 		sockMutex.unlock();
 	}