Content-driven HDR output and Legion Go 2 display script#2148
Open
matte-schwartz wants to merge 3 commits into
Open
Content-driven HDR output and Legion Go 2 display script#2148matte-schwartz wants to merge 3 commits into
matte-schwartz wants to merge 3 commits into
Conversation
This uses the current content being displayed to determine whether or not to engage an HDR colorspace.
Add VFP timings for the non-VRR frame limiter, and enable content_driven HDR mode to workaround lack of Steam support for backlight control while the Go 2's panel is outputting PQ content. This can be re-assessed when Steam supports internal panels with HDR that behave less like the Steam Deck OLED when it comes to brightness adjustment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some HDR panels (e.g. Legion Go 2) bypass sysfs backlight control while running in PQ mode, leaving the Steam brightness slider non-functional for SDR content and non-linear for HDR content. As a workaround, add an opt-in content-driven HDR mode that switches the panel to HDR only while an app is actively submitting HDR content.
This doesn't fix the underlying issue so the slider will still be non-linear for HDR content, but it makes the device more usable for SDR content and the Steam UI until there's proper brightness-control support for internal HDR panels that cannot blend hardware and gamma brightness control together.