Skip to content

rendervulkan: evict stale screenshot images, for reuse #2170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
misyltoad merged 2 commits into from
May 15, 2026
+56 −26
Merged

rendervulkan: evict stale screenshot images, for reuse #2170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98e0414
rendervulkan: evict stale screenshot images, for reuse
oSoMoN May 11, 2026
beccb1f
rendervulkan: define two separate texture pools for screenshots and v…
oSoMoN May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 52 additions & 24 deletions src/rendervulkan.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3247,9 +3247,11 @@ bool vulkan_remake_swapchain( void )

g_device.vk.DestroySwapchainKHR( g_device.device(), pOutput->swapChain, nullptr );

// Delete screenshot image to be remade if needed
for (auto& pScreenshotImage : pOutput->pScreenshotImages)
pScreenshotImage = nullptr;
// Delete screenshot/capture textures to be remade if needed
for (auto& pScreenshotTexture : pOutput->pScreenshotTextures)
pScreenshotTexture = nullptr;
for (auto& pCaptureTexture : pOutput->pCaptureTextures)
pCaptureTexture = nullptr;

bool bRet = vulkan_make_swapchain( pOutput );
assert( bRet ); // Something has gone horribly wrong!
Expand Down Expand Up @@ -3343,9 +3345,11 @@ bool vulkan_remake_output_images()

pOutput->nOutImage = 0;

// Delete screenshot image to be remade if needed
for (auto& pScreenshotImage : pOutput->pScreenshotImages)
pScreenshotImage = nullptr;
// Delete screenshot/capture textures to be remade if needed
for (auto& pScreenshotTexture : pOutput->pScreenshotTextures)
pScreenshotTexture = nullptr;
for (auto& pCaptureTexture : pOutput->pCaptureTextures)
pCaptureTexture = nullptr;

bool bRet = vulkan_make_output_images( pOutput );
assert( bRet );
Expand Down Expand Up @@ -3593,42 +3597,66 @@ void vulkan_garbage_collect( void )
g_device.garbageCollect();
}

gamescope::Rc<CVulkanTexture> vulkan_acquire_screenshot_texture(uint32_t width, uint32_t height, bool exportable, uint32_t drmFormat, EStreamColorspace colorspace)
static gamescope::Rc<CVulkanTexture> acquire_pooled_texture( auto& pool, uint32_t width, uint32_t height, bool exportable, uint32_t drmFormat, EStreamColorspace colorspace )
{
for (auto& pScreenshotImage : g_output.pScreenshotImages)
for (auto& pTexture : pool)
{
if (pScreenshotImage == nullptr)
// Evict a stale texture and reuse the slot
if (pTexture && pTexture->GetRefCount() == 0 &&
(width != pTexture->width() ||
height != pTexture->height() ||
drmFormat != pTexture->drmFormat()))
{
pTexture = nullptr;
}

if (pTexture == nullptr)
{
pScreenshotImage = new CVulkanTexture();
pTexture = new CVulkanTexture();

CVulkanTexture::createFlags screenshotImageFlags;
screenshotImageFlags.bMappable = true;
screenshotImageFlags.bTransferDst = true;
screenshotImageFlags.bStorage = true;
CVulkanTexture::createFlags textureFlags;
textureFlags.bMappable = true;
textureFlags.bTransferDst = true;
textureFlags.bStorage = true;
if (exportable || drmFormat == DRM_FORMAT_NV12) {
screenshotImageFlags.bExportable = true;
screenshotImageFlags.bLinear = true; // TODO: support multi-planar DMA-BUF export via PipeWire
textureFlags.bExportable = true;
textureFlags.bLinear = true; // TODO: support multi-planar DMA-BUF export via PipeWire
}

bool bSuccess = pScreenshotImage->BInit( width, height, 1u, drmFormat, screenshotImageFlags );
pScreenshotImage->setStreamColorspace(colorspace);
bool bSuccess = pTexture->BInit( width, height, 1u, drmFormat, textureFlags );
pTexture->setStreamColorspace(colorspace);

assert( bSuccess );
}

if (pScreenshotImage->GetRefCount() != 0 ||
width != pScreenshotImage->width() ||
height != pScreenshotImage->height() ||
drmFormat != pScreenshotImage->drmFormat())
if (pTexture->GetRefCount() != 0 ||
width != pTexture->width() ||
height != pTexture->height() ||
drmFormat != pTexture->drmFormat())
continue;

return pScreenshotImage.get();
return pTexture.get();
}

vk_log.errorf("Unable to acquire screenshot texture. Out of textures.");
return nullptr;
}

gamescope::Rc<CVulkanTexture> vulkan_acquire_screenshot_texture(uint32_t width, uint32_t height, bool exportable, uint32_t drmFormat, EStreamColorspace colorspace)
{
auto texture = acquire_pooled_texture(g_output.pScreenshotTextures, width, height, exportable, drmFormat, colorspace);
if (!texture)
vk_log.errorf("Unable to acquire screenshot texture. Out of textures.");
return texture;
}

gamescope::Rc<CVulkanTexture> vulkan_acquire_capture_texture(uint32_t width, uint32_t height, bool exportable, uint32_t drmFormat, EStreamColorspace colorspace)
{
auto texture = acquire_pooled_texture(g_output.pCaptureTextures, width, height, exportable, drmFormat, colorspace);
if (!texture)
vk_log.errorf("Unable to acquire capture texture. Out of textures.");
return texture;
}

// Internal display's native brightness.
float g_flInternalDisplayBrightnessNits = 500.0f;

Expand Down
4 changes: 3 additions & 1 deletion src/rendervulkan.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,7 @@ std::optional<uint64_t> vulkan_composite( struct FrameInfo_t *frameInfo, gamesco
void vulkan_wait( uint64_t ulSeqNo, bool bReset );
gamescope::Rc<CVulkanTexture> vulkan_get_last_output_image( bool partial, bool defer );
gamescope::Rc<CVulkanTexture> vulkan_acquire_screenshot_texture(uint32_t width, uint32_t height, bool exportable, uint32_t drmFormat, EStreamColorspace colorspace = k_EStreamColorspace_Unknown);
gamescope::Rc<CVulkanTexture> vulkan_acquire_capture_texture(uint32_t width, uint32_t height, bool exportable, uint32_t drmFormat, EStreamColorspace colorspace = k_EStreamColorspace_Unknown);

void vulkan_present_to_window( void );

Expand Down Expand Up @@ -537,7 +538,8 @@ struct VulkanOutput_t
uint32_t uOutputFormat = DRM_FORMAT_INVALID;
uint32_t uOutputFormatOverlay = DRM_FORMAT_INVALID;

std::array<gamescope::OwningRc<CVulkanTexture>, 2> pScreenshotImages;
std::array<gamescope::OwningRc<CVulkanTexture>, 2> pScreenshotTextures;
std::array<gamescope::OwningRc<CVulkanTexture>, 2> pCaptureTextures;

// NIS and FSR
gamescope::OwningRc<CVulkanTexture> tmpOutput;
Expand Down
2 changes: 1 addition & 1 deletion src/steamcompmgr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2405,7 +2405,7 @@ static void paint_pipewire()
}

gamescope::Rc<CVulkanTexture> pRGBTexture = s_pPipewireBuffer->texture->isYcbcr()
? vulkan_acquire_screenshot_texture( uWidth, uHeight, false, DRM_FORMAT_XRGB2101010 )
? vulkan_acquire_capture_texture( uWidth, uHeight, false, DRM_FORMAT_XRGB2101010 )
: gamescope::Rc<CVulkanTexture>{ s_pPipewireBuffer->texture };

gamescope::Rc<CVulkanTexture> pYUVTexture = s_pPipewireBuffer->texture->isYcbcr() ? s_pPipewireBuffer->texture : nullptr;
Expand Down