steamcompmgr: do not forcefully snap focus windows to (0, 0)#2177
Open
oSoMoN wants to merge 1 commit into
Open
steamcompmgr: do not forcefully snap focus windows to (0, 0)#2177oSoMoN wants to merge 1 commit into
oSoMoN wants to merge 1 commit into
Conversation
The compositor already ignores a focus window's X11 origin when computing layer offsets. Fix MouseCursor::paint to match, using origin (0, 0) for the focus window when positioning the cursor. Some games draw a plain background window and another smaller window on top with the actual game contents, which they center by requesting a specific position on screen. Gamescope would force that content window back to (0, 0), only to be requested to move it back to where the game wants it, endlessly, which would result in bad flickering. Such a game is Nobunaga's Ambition: Hadou when played in borderless mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compositor already ignores a focus window's X11 origin when computing layer offsets. Fix MouseCursor::paint to match, using origin (0, 0) for the focus window when positioning the cursor.
Some games draw a plain background window and another smaller window on top with the actual game contents, which they center by requesting a specific position on screen. Gamescope would force that content window back to (0, 0), only to be requested to move it back to where the game wants it, endlessly, which would result in bad flickering. Such a game is Nobunaga's Ambition: Hadou when played in borderless mode.