[TF2] Bring Back Quickplay

[hankjordan]

Description

Re-enables TF2's Quickplay system by bringing the existing source code back into the build.

This does not replace Casual / Competitive, or any of the existing Matchmaking system. It merely acts as a compliment.

Details

• Adds tf_quickplay_ui.cpp, tf_quickplay.h, and tf_quickplay_shared.h to the build
• Adds play_quickplay command handler to the matchmaking dashboard playlist panel
• Ports SchemaMap_t / GetMapForName / GetMapForIndex to MapDef_t / GetMasterMapDefByName / GetMasterMapsList
• Re-adds eQuickplayType field to MapDef_t and parses quickplay_type from items_game.txt using the existing s_pszQuickplayMatchTypes string table
• Quickplay scoring and fullness checks now account for party size via GetNumPartyMembers()
• Removes tf_quickplay_shared.cpp from the build (duplicate CMvMMissionSet definitions already in tf_matchmaking_shared.cpp)

Next Steps

This PR allows the Quickplay menu to be opened via the OpenQuickplayDialog command
but does not provide a way for the user to open it directly in the UI.

Some minor changes will need to be made upstream.

• Add QuickplayEntry to resource/ui/MatchMakingPlayList.res (see below)
• Create main_menu/main_menu_button_quickplay image asset (see below)
• Add MMenu_PlayList_Quickplay_Button / MMenu_PlayList_Quickplay_Desc localization strings (see below)
• Re-add quickplay_type keys to map definitions in items_game.txt
  • Quickplay functions without this, but the new-user-friendly scoring bonus won't do anything
• Re-enable Game Coordinator Quickplay scoring and _registered tag filtering
  • Quickplay functions without this, but servers can fake their ranking and registration

Example changes

tf/resource/ui/MatchMakingPlayList.res

Insert between MvMEntry and ServerBrowserEntry, shift all entries below by 50

"QuickplayEntry"
{
    "ControlName"           "CPlayListEntry"
    "fieldName"             "QuickplayEntry"
    "xpos"                  "0"
    "ypos"                  "153"
    "tall"                  "45"
    "wide"                  "255"
    "proportionaltoparent"  "1"

    "image_name"            "main_menu/main_menu_button_quickplay"
    "button_token"          "#MMenu_PlayList_Quickplay_Button"
    "button_command"        "play_quickplay"
    "desc_token"            "#MMenu_PlayList_Quickplay_Desc"

    if_event
    {
        "ypos"              "203"
    }
}

tf/resource/tf_english.txt

New localization strings for the playlist entry

"MMenu_PlayList_Quickplay_Button"   "Quickplay"
"MMenu_PlayList_Quickplay_Desc"     "Quickly find and join a game server running your chosen game mode."

tf/materials/vgui/main_menu/main_menu_button_quickplay.vtf

Some art for what a Quickplay button might look like

Notes

• The _registered tag filter is commented out since it's no longer set for any server
• Party members do not auto-join when using Quickplay (consistent with the server browser)

Issues

• Closes [TF2] Feature request: Bring Back Quickplay Source-1-Games#7817
• Closes [TF2] Remove unused cvar tf_server_identity_disable_quickplay for deprecated quickplay system Source-1-Games#6088

Preview

[Gavitro]

I appreciate your effort, but in my opinion, Quickplay and Casual shouldn't co-exist. Either the former is reverted fully, or the latter gets many quality-of-life improvements. I could go more in-depth, but this comments section is inevitably going to get heated, so I'll leave it at that.

Regardless though, if Valve ever plans on doing something about the matter, they would probably handle it themselves instead of accepting pull requests.

[woahloxk]

im sorry, i dont like idea of quick play at all

[linuxgamer]

im sorry, i dont like idea of quick play at all

You still could use matchmaker and not the "filthy" quickplay AT ALL!:

This does not replace Casual / Competitive, or any of the existing Matchmaking system. It merely acts as a compliment.

[JoriKos]

I don't see a point in bringing back an inferior system that's outdated. Most people that want Quickplay (and all of them haven't played during the Quickplay era of TF2, btw) are actually complaining about server settings and never want this UI back.

[Pandaptable]

The primary issue is that solely bringing back quickplay will just split the playerbase at worst... and at best become unused.
Well more than likely it'll be botted to all hell (just like it was prior to removal) and then become unused.

[linuxgamer]

@JoriKos Well, lots of people see the point (and quickplay inst exactly inferior, though it has its flaws (also matchmaker will keep breaking even if server settings change: map bloat, lol)). point about quickplay fans never playing tf2 during quickplay era is means nothing...
I think it will be better for everyone to just shut up and dont fight here about "superior" systems, tho.(else kisak-valve or whoever moderates this will just lock the discussion)

[Pandaptable]

@JoriKos Well, lots of people see the point (and quickplay inst exactly inferior, though it has its flaws (also matchmaker will keep breaking even if server settings change: map bloat, lol)). point about quickplay fans never playing tf2 during quickplay era is means nothing... I think it will be better for everyone to just shut up and dont fight here about "superior" systems, tho.(else kisak-valve or whoever moderates this will just lock the discussion)

yes! lots of people do see the point! the ones spouting the same stuff as every youtuber who also don't actually know about anything internally

None of the people spouting about quickplay vs casual understand the game coordinator... map bloat is a buzzword that means quite literally nothing in this discussion

[JoriKos]

@JoriKos Well, lots of people see the point

Talk to any of them and they will talk about the server settings like round timers, no best of 3, etc. They will never talk about the Quickplay UI that's being implemented here.

(and quickplay inst exactly inferior...

Yeah it is, it has worse UX (can't select multiple maps, can't select multiple game modes, can't choose to queue for multiple maps at the same time. It's either a random map out of all the maps, or you have to choose one map yourself)

point about quickplay fans never playing tf2 during quickplay era is means nothing...

People who have never played during Quickplay era talking about how good Quickplay was are speaking from no experience. They are repeating what TF2 YouTubers are saying and cannot form their own arguments, because they just resort to 'watch this video' or saying you're wrong with no counterarguments. I've had loads of discussions with people that want Quickplay back, they always end up just talking about how I should watch some YouTuber's video about it instead of being able to hold their own in an argument. People that haven't played during Quickplay cannot be a valid source on how much 'better' Quickplay was.

[linuxgamer]

@Pandaptable

the ones spouting the same stuff as every youtuber

same can said about casual fans liking their system. Also what is the "secret" internal stuff that youtubers nor the players dont know?
map bloat does exist: good luck to make a system that is able to distribute small amount of people across 110+ maps with no issues.

I should follow tho (and recommend for you to do the same) the thing i already said: no fighting over tf2 hot takes on a fkin github...

[linuxgamer]

@JoriKos we can go fight bout that somewhere else lol

[Pandaptable]

@Pandaptable

the ones spouting the same stuff as every youtuber

same can said about casual fans liking their system. Also what is the "secret" internal stuff that youtubers nor the players dont know? map bloat does exist: good luck to make a system that is able to distribute small amount of people across 110+ maps with no issues.

I should follow tho (and recommend for you to do the same) the thing i already said: no fighting over tf2 hot takes on a fkin github...

the "internal" stuff is... the game coordinator. it has literally never been leaked, not even people with licensed source engine access have the game coordinator
the only way to figure out how it works is reversing the logic... which sucks!

"map bloar" again does NOT apply in this conversation as it's an entirely different issue irrelevant to quickplay vs casual

You also seemed to very blatantly ignore several other points i made, and proceeded to throw expletives at me for no apparent reason.. however.. an ACTUAL issue with casual that no one ever brings up is that new matches will only be created if 12 people are queuing for a match. Wonder why! It's only like no one who wants quickplay understands the systems!

[linuxgamer]

@Pandaptable

You also seemed to very blatantly ignore several other points i made

You ignore my point about not fighting about hot takes under github pr. I will be glad to continue chatting somewhere else (and talkin bout missed points as well)

[Pandaptable]

@Pandaptable

You also seemed to very blatantly ignore several other points i made

You ignore my point about not fighting about hot takes under github pr. I will be glad to continue chatting somewhere else (and talkin bout missed points as well)

I'm not fighting, you are the one that essentially started this entire discussion with attacking me, not sure how that has me being someone trying to fight.
Moving the discussion elsewhere would likely result in more of that so no thank you, I will just end it here :)

[linuxgamer]

@Pandaptable

started this entire discussion with attacking me

i didnt even "attack" you (great choice of words to demonize me! i didnt even want to offend you, sry) I was fighting with another guy, but you appeared in chat, said your thing and blamed me for "selfdefense": responding to you (ill use scary words too)

At least ending the fight is a damn good idea from your side.

[eno26]

holy reddit 101 over here

[kisak-valve]

Regardless of opinions on the matter, this should be discussed on the preexisting issue report tracking the topic. Fragmenting the discussion across multiple issue trackers is non-productive.

Please see ValveSoftware/Source-1-Games#7817 for the ongoing discussion.