Fix a crash when a networked entity is parented to a server-only entity#1878
Open
RaphaelIT7 wants to merge 1 commit intoValveSoftware:masterfrom
Open
Fix a crash when a networked entity is parented to a server-only entity#1878RaphaelIT7 wants to merge 1 commit intoValveSoftware:masterfrom
RaphaelIT7 wants to merge 1 commit intoValveSoftware:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the case that a networked entity was parented to a server-only entity, it would have resulted in a crash.
This happened due to
pEnt-> GetNetworkParent ()returning the server-only entity, but whenpEdict = pParent->edict();is executed,pEdictwould becomeNULLsince it's server-only and on the next iteration it would crash when attempting to runpEdict->GetNetworkable()This was originally shown to me by @legokidlogan and was fixed in GMod's dev branch after he reported it there, but I think this is something that should also be fixed here.
Example code to test it with (though I couldn't test it on the latest sdk build due to the engine.dll crashing on startup?)