fix ‘falsey’ default value generation

Author: eakoli

pydbml/renderer/dbml/default/column.py

@@ -24,7 +24,7 @@ def render_options(model: Column) -> str:
         options.append('pk')
     if model.autoinc:
         options.append('increment')
-    if model.default:
+    if model.default is not None:
         options.append(f'default: {default_to_str(model.default)}')
     if model.unique:
         options.append('unique')

test/conftest.py

@@ -87,6 +87,28 @@ def string_column_with_table(db: Database, table1: Table, string_column: Column)
     db.add(table1)
     return string_column
 
+@pytest.fixture
+def boolean_column() -> Column:
+    return Column(
+        name='enabled',
+        type='boolean',
+        pk=False,
+        autoinc=False,
+        unique=False,
+        not_null=True,
+        default=False,
+        comment='This is a defaulted boolean column',
+        note=Note('This is a note for the column'),
+        properties={'foo': 'bar', 'baz': "qux\nqux"}
+    )
+
+
+@pytest.fixture
+def boolean_column_with_table(db: Database, table1: Table, boolean_column: Column) -> Column:
+    table1.add_column(boolean_column)
+    db.add(table1)
+    return boolean_column
+
 
 @pytest.fixture
 def table1() -> Table:

test/test_data/integration1.dbml

@@ -12,7 +12,7 @@ Enum "level" {
 Table "Employees" as "emp" {
     "id" integer [pk, increment]
     "name" varchar [note: 'Full employee name']
-    "age" number
+    "age" number [default: 0]
     "level" level
     "favorite_book_id" integer
 }

test/test_renderer/test_dbml/test_column.py

@@ -133,7 +133,7 @@ def test_enum(simple_column_with_table: Column, enum1: Enum) -> None:
     def test_complex(complex_column_with_table: Column) -> None:
         expected = (
             "// This is a counter column\n"
-            '"counter" "product status" [pk, increment, unique, not null, note: \'This is '
+            '"counter" "product status" [pk, increment, default: 0, unique, not null, note: \'This is '
             "a note for the column']"
         )
         assert render_column(complex_column_with_table) == expected
@@ -147,3 +147,11 @@ def test_string(string_column_with_table: Column) -> None:
         )
         assert render_column(string_column_with_table) == expected
 
+    @staticmethod
+    def test_boolean(boolean_column_with_table: Column) -> None:
+        expected = (
+            "// This is a defaulted boolean column\n"
+            '"enabled" boolean [default: False, not null, note: \'This is '
+            "a note for the column']"
+        )
+        assert render_column(boolean_column_with_table) == expected

test/test_renderer/test_sql/test_default/test_column.py

@@ -26,3 +26,12 @@ def test_string(string_column: Column) -> None:
             "'value''s'"
         )
         assert render_column(string_column) == expected
+
+    @staticmethod
+    def test_string(boolean_column: Column) -> None:
+        expected = (
+            "-- This is a defaulted boolean column\n"
+            '"enabled" boolean NOT NULL DEFAULT '
+            "False"
+        )
+        assert render_column(boolean_column) == expected