remove support for PHP 7.0 and adopt PHP 7.1

Author: VasekPurchart

.travis.yml

@@ -3,7 +3,6 @@ language: php
 sudo: false
 
 php:
-  - 7.0
   - 7.1
   - 7.2
   - nightly

build/cs-ruleset.xml

@@ -1,9 +1,6 @@
 <?xml version="1.0"?>
 <ruleset name="ConsistenceCodingStandard">
-	<rule ref="../vendor/consistence/coding-standard/Consistence/ruleset.xml">
-		<exclude name="SlevomatCodingStandard.Classes.ClassConstantVisibility"/><!-- requires 7.1+ -->
-		<exclude name="SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue"/><!-- requires PHP 7.1+ -->
-	</rule>
+	<rule ref="../vendor/consistence/coding-standard/Consistence/ruleset.xml"/>
 	<rule ref="SlevomatCodingStandard.Files.TypeNameMatchesFileName">
 		<properties>
 			<property name="rootNamespaces" type="array" value="

composer.json

@@ -11,7 +11,7 @@
 		}
 	],
 	"require": {
-		"php": "~7.0",
+		"php": "~7.1",
 		"phing/phing": "~2.16"
 	},
 	"require-dev": {

src/SymfonyCommandTask.php

@@ -9,8 +9,8 @@
 class SymfonyCommandTask extends \ExecTask
 {
 
-	const PROPERTY_DEFAULT_EXECUTABLE = 'symfony-command.default.executable';
-	const PROPERTY_DEFAULT_APP = 'symfony-command.default.app';
+	public const PROPERTY_DEFAULT_EXECUTABLE = 'symfony-command.default.executable';
+	public const PROPERTY_DEFAULT_APP = 'symfony-command.default.app';
 
 	/** @var bool check return code by default */
 	protected $checkreturn = true;
@@ -30,23 +30,23 @@ class SymfonyCommandTask extends \ExecTask
 	/**
 	 * @param string $executable
 	 */
-	public function setExecutable($executable)
+	public function setExecutable($executable): void
 	{
 		$this->executable = $executable;
 		parent::setExecutable($executable);
 	}
 
-	public function setApp(string $app)
+	public function setApp(string $app): void
 	{
 		$this->app = $app;
 	}
 
-	public function setCmd(string $cmd)
+	public function setCmd(string $cmd): void
 	{
 		$this->cmd = $cmd;
 	}
 
-	public function main()
+	public function main(): void
 	{
 		if ($this->app === null) {
 			$defaultApp = $this->getProject()->getProperty(self::PROPERTY_DEFAULT_APP);

tests/HelloWorldCommand.php

@@ -10,17 +10,17 @@
 class HelloWorldCommand extends \Symfony\Component\Console\Command\Command
 {
 
-	const NAME = 'hello:world';
+	public const NAME = 'hello:world';
 
-	protected function configure()
+	protected function configure(): void
 	{
 		$this->setName(self::NAME);
 		$description = 'Hello world test command';
 		$this->setDescription($description);
 		$this->setHelp($description);
 	}
 
-	protected function execute(InputInterface $input, OutputInterface $output)
+	protected function execute(InputInterface $input, OutputInterface $output): void
 	{
 		// empty
 	}

tests/SymfonyCommandTaskIntegrationTest.php

@@ -10,7 +10,7 @@
 class SymfonyCommandTaskIntegrationTest extends \PHPUnit\Framework\TestCase
 {
 
-	public function testCallCommand()
+	public function testCallCommand(): void
 	{
 		$tester = new PhingTester(__DIR__ . '/symfony-command-task-integration-test.xml');
 		$target = __FUNCTION__;
@@ -23,7 +23,7 @@ public function testCallCommand()
 		), $target, Project::MSG_VERBOSE);
 	}
 
-	public function testCallCommandWithCustomExecutable()
+	public function testCallCommandWithCustomExecutable(): void
 	{
 		$tester = new PhingTester(__DIR__ . '/symfony-command-task-integration-test.xml');
 		$target = __FUNCTION__;
@@ -36,7 +36,7 @@ public function testCallCommandWithCustomExecutable()
 		), $target, Project::MSG_VERBOSE);
 	}
 
-	public function testCallCommandWithCustomApp()
+	public function testCallCommandWithCustomApp(): void
 	{
 		$tester = new PhingTester(__DIR__ . '/symfony-command-task-integration-test.xml');
 		$target = __FUNCTION__;
@@ -49,7 +49,7 @@ public function testCallCommandWithCustomApp()
 		), $target, Project::MSG_VERBOSE);
 	}
 
-	public function testCallCommandWithCustomExecutableAndApp()
+	public function testCallCommandWithCustomExecutableAndApp(): void
 	{
 		$tester = new PhingTester(__DIR__ . '/symfony-command-task-integration-test.xml');
 		$target = __FUNCTION__;
@@ -62,7 +62,7 @@ public function testCallCommandWithCustomExecutableAndApp()
 		), $target, Project::MSG_VERBOSE);
 	}
 
-	public function testCallCommandWithAppAsExecutable()
+	public function testCallCommandWithAppAsExecutable(): void
 	{
 		$tester = new PhingTester(__DIR__ . '/symfony-command-task-integration-test.xml');
 		$target = __FUNCTION__;
@@ -74,7 +74,7 @@ public function testCallCommandWithAppAsExecutable()
 		), $target, Project::MSG_VERBOSE);
 	}
 
-	public function testCallCommandAndOverrideDefaults()
+	public function testCallCommandAndOverrideDefaults(): void
 	{
 		$tester = new PhingTester(__DIR__ . '/symfony-command-task-integration-test.xml');
 		$target = __FUNCTION__;
@@ -87,7 +87,7 @@ public function testCallCommandAndOverrideDefaults()
 		), $target, Project::MSG_VERBOSE);
 	}
 
-	public function testMissingApp()
+	public function testMissingApp(): void
 	{
 		$tester = new PhingTester(__DIR__ . '/symfony-command-task-integration-test.xml');
 		$target = __FUNCTION__;