deduplicate testing calling command using data provider

Author: petrduda

tests/SymfonyCommandTaskIntegrationTest.php

@@ -4,62 +4,70 @@
 
 namespace VasekPurchart\Phing\SymfonyCommand;
 
+use Generator;
 use PHPUnit\Framework\Assert;
 use Project;
 use VasekPurchart\Phing\PhingTester\PhingTester;
 
 class SymfonyCommandTaskIntegrationTest extends \PHPUnit\Framework\TestCase
 {
 
-	public function testCallCommand(): void
+	/**
+	 * @return mixed[][]|\Generator
+	 */
+	public function callCommandDataProvider(): Generator
 	{
-		$tester = new PhingTester(__DIR__ . '/symfony-command-task-integration-test.xml');
-		$target = __FUNCTION__;
-		$tester->executeTarget($target);
-
-		$tester->assertLogMessageRegExp(sprintf(
-			'~executing.+%s.+%s.+hello:world~i',
-			$tester->getProject()->getProperty(__FUNCTION__ . '.default.executable'),
-			$tester->getProject()->getProperty(__FUNCTION__ . '.default.app')
-		), $target, Project::MSG_VERBOSE);
+		yield 'call command' => [
+			'target' => 'testCallCommand',
+			'expectedLogMessageRegExpExecutable' => '.default.executable',
+			'expectedLogMessageRegExpApp' => '.default.app',
+		];
+
+		yield 'call command with custom executable' => [
+			'target' => 'testCallCommandWithCustomExecutable',
+			'expectedLogMessageRegExpExecutable' => '.test.executable',
+			'expectedLogMessageRegExpApp' => '.default.app',
+		];
+
+		yield 'call command with custom app' => [
+			'target' => 'testCallCommandWithCustomApp',
+			'expectedLogMessageRegExpExecutable' => '.default.executable',
+			'expectedLogMessageRegExpApp' => '.test.app',
+		];
+
+		yield 'call command with custom executable and app' => [
+			'target' => 'testCallCommandWithCustomExecutableAndApp',
+			'expectedLogMessageRegExpExecutable' => '.test.executable',
+			'expectedLogMessageRegExpApp' => '.test.app',
+		];
+
+		yield 'call command and override defaults' => [
+			'target' => 'testCallCommandAndOverrideDefaults',
+			'expectedLogMessageRegExpExecutable' => '.test.executable',
+			'expectedLogMessageRegExpApp' => '.test.app',
+		];
 	}
 
-	public function testCallCommandWithCustomExecutable(): void
+	/**
+	 * @dataProvider callCommandDataProvider
+	 *
+	 * @param string $target
+	 * @param string $expectedLogMessageRegExpExecutable
+	 * @param string $expectedLogMessageRegExpApp
+	 */
+	public function testCallCommand(
+		string $target,
+		string $expectedLogMessageRegExpExecutable,
+		string $expectedLogMessageRegExpApp
+	): void
 	{
 		$tester = new PhingTester(__DIR__ . '/symfony-command-task-integration-test.xml');
-		$target = __FUNCTION__;
 		$tester->executeTarget($target);
 
 		$tester->assertLogMessageRegExp(sprintf(
 			'~executing.+%s.+%s.+hello:world~i',
-			$tester->getProject()->getProperty(__FUNCTION__ . '.test.executable'),
-			$tester->getProject()->getProperty(__FUNCTION__ . '.default.app')
-		), $target, Project::MSG_VERBOSE);
-	}
-
-	public function testCallCommandWithCustomApp(): void
-	{
-		$tester = new PhingTester(__DIR__ . '/symfony-command-task-integration-test.xml');
-		$target = __FUNCTION__;
-		$tester->executeTarget($target);
-
-		$tester->assertLogMessageRegExp(sprintf(
-			'~executing.+%s.+%s.+hello:world~i',
-			$tester->getProject()->getProperty(__FUNCTION__ . '.default.executable'),
-			$tester->getProject()->getProperty(__FUNCTION__ . '.test.app')
-		), $target, Project::MSG_VERBOSE);
-	}
-
-	public function testCallCommandWithCustomExecutableAndApp(): void
-	{
-		$tester = new PhingTester(__DIR__ . '/symfony-command-task-integration-test.xml');
-		$target = __FUNCTION__;
-		$tester->executeTarget($target);
-
-		$tester->assertLogMessageRegExp(sprintf(
-			'~executing.+%s.+%s.+hello:world~i',
-			$tester->getProject()->getProperty(__FUNCTION__ . '.test.executable'),
-			$tester->getProject()->getProperty(__FUNCTION__ . '.test.app')
+			$tester->getProject()->getProperty($target . $expectedLogMessageRegExpExecutable),
+			$tester->getProject()->getProperty($target . $expectedLogMessageRegExpApp)
 		), $target, Project::MSG_VERBOSE);
 	}
 
@@ -75,19 +83,6 @@ public function testCallCommandWithAppAsExecutable(): void
 		), $target, Project::MSG_VERBOSE);
 	}
 
-	public function testCallCommandAndOverrideDefaults(): void
-	{
-		$tester = new PhingTester(__DIR__ . '/symfony-command-task-integration-test.xml');
-		$target = __FUNCTION__;
-		$tester->executeTarget($target);
-
-		$tester->assertLogMessageRegExp(sprintf(
-			'~executing.+%s.+%s.+hello:world~i',
-			$tester->getProject()->getProperty(__FUNCTION__ . '.test.executable'),
-			$tester->getProject()->getProperty(__FUNCTION__ . '.test.app')
-		), $target, Project::MSG_VERBOSE);
-	}
-
 	public function testMissingApp(): void
 	{
 		$buildFilePath = __DIR__ . '/symfony-command-task-integration-test.xml';