Skip to content

allow task cancellation#5

Open
salfab wants to merge 1 commit into
developfrom
feature/CancellationToken
Open

allow task cancellation#5
salfab wants to merge 1 commit into
developfrom
feature/CancellationToken

Conversation

@salfab

@salfab salfab commented Apr 9, 2018

Copy link
Copy Markdown
Contributor

Fixes issue #3

@@ -13,7 +15,7 @@ public interface IEventPublisher
/// <typeparam name="TEvent">The type of the event.</typeparam>
/// <param name="ev">The event.</param>
/// <returns>A promise of completion</returns>

@ylerjen ylerjen Apr 11, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, also update the xml doc

@@ -24,6 +26,6 @@ public interface IEventPublisher
/// <returns>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, also update the xml doc

@ylerjen

ylerjen commented Apr 11, 2018

Copy link
Copy Markdown
Member

Update the package version number ?

@ylerjen ylerjen added the enhancement New feature or request label Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants