feat(cli): validate --parser against valid set via click.Choice (#77)

Author: KylinMountain

openkb/cli.py

@@ -43,6 +43,7 @@ def filter(self, record: logging.LogRecord) -> bool:
 from openkb.config import DEFAULT_CONFIG, load_config, save_config, load_global_config, register_kb
 from openkb.converter import convert_document
 from openkb.log import append_log
+from openkb.parsers.registry import VALID_PARSERS
 from openkb.schema import AGENTS_MD
 
 # Suppress warnings after all imports — markitdown overrides filters at import time
@@ -576,7 +577,8 @@ def init(model, language):
 @cli.command()
 @click.argument("path")
 @click.option("--parser", "parser_override", default=None,
-              help="Override the configured parser for this run (local|mineru|mistral|vlm).")
+              type=click.Choice(VALID_PARSERS),
+              help="Override the configured parser for this run.")
 @click.pass_context
 def add(ctx, path, parser_override):
     """Add a document or directory of documents at PATH to the knowledge base.

openkb/parsers/registry.py

@@ -6,7 +6,7 @@
 from openkb.parsers.base import Parser
 from openkb.parsers.local import LocalParser
 
-_VALID = ("local", "mineru", "mistral", "vlm")
+VALID_PARSERS = ("local", "mineru", "mistral", "vlm")
 
 
 def get_parser(
@@ -34,5 +34,5 @@ def get_parser(
         from openkb.parsers.mineru import MineruParser
         return MineruParser(opts)
     raise ValueError(
-        f"Unknown parser {name!r}. Valid options: {', '.join(_VALID)}."
+        f"Unknown parser {name!r}. Valid options: {', '.join(VALID_PARSERS)}."
     )

tests/test_add_command.py

@@ -164,3 +164,12 @@ def test_add_single_file_threads_parser_override(tmp_path):
     # parser_override must reach convert_document
     assert cd.call_args.kwargs.get("parser_override") == "mistral" \
         or (len(cd.call_args.args) >= 3 and cd.call_args.args[2] == "mistral")
+
+
+def test_add_parser_option_rejects_invalid_choice(tmp_path):
+    from click.testing import CliRunner
+    from openkb.cli import cli
+    runner = CliRunner()
+    result = runner.invoke(cli, ["add", "--parser", "bogus", str(tmp_path / "x.pdf")])
+    assert result.exit_code != 0
+    assert "bogus" in result.output or "Invalid value" in result.output