fix(cli): recompile --refresh-schema no-ops when AGENTS.md absent; tighten guard tests

Match the spec (and the helper's own docstring): _refresh_schema returns
early when wiki/AGENTS.md is missing rather than materializing the default
(get_agents_md already falls back to it at runtime). Tighten the doc/--all
guard tests to assert the exact message + that no compile runs, and add the
missing-AGENTS.md no-op test.

Author: KylinMountain

openkb/cli.py

@@ -1083,13 +1083,16 @@ def _refresh_schema(wiki_dir: Path) -> bool:
     file is missing or already identical. Returns True if it overwrote.
     """
     agents_file = wiki_dir / "AGENTS.md"
-    current = agents_file.read_text(encoding="utf-8") if agents_file.exists() else ""
+    if not agents_file.exists():
+        # No-op when missing: get_agents_md() already falls back to the
+        # bundled AGENTS_MD default at runtime, so there is nothing to refresh.
+        return False
+    current = agents_file.read_text(encoding="utf-8")
     if current == AGENTS_MD:
         return False
-    if agents_file.exists():
-        backup = wiki_dir / "AGENTS.md.bak"
-        backup.write_text(current, encoding="utf-8")
-        click.echo(f"  Backed up existing schema to {backup.relative_to(wiki_dir.parent)}")
+    backup = wiki_dir / "AGENTS.md.bak"
+    backup.write_text(current, encoding="utf-8")
+    click.echo(f"  Backed up existing schema to {backup.relative_to(wiki_dir.parent)}")
     agents_file.write_text(AGENTS_MD, encoding="utf-8")
     click.echo("  Refreshed wiki/AGENTS.md to the current schema.")
     return True

tests/test_recompile.py

@@ -224,15 +224,19 @@ def test_recompile_skips_long_missing_summary(kb_dir):
 
 def test_recompile_requires_doc_or_all(kb_dir):
     _seed_short(kb_dir)
-    result = _invoke(kb_dir, ["recompile"])
-    assert result.exit_code != 0 or "Specify" in result.output or "--all" in result.output
+    with patch("openkb.agent.compiler.compile_short_doc", new_callable=AsyncMock) as short:
+        result = _invoke(kb_dir, ["recompile"])
+    # Usage guard echoes a message and returns (exit 0); no compile runs.
+    assert "Specify a document name or pass --all" in result.output
+    short.assert_not_called()
 
 
 def test_recompile_doc_and_all_conflict(kb_dir):
     _seed_short(kb_dir)
-    result = _invoke(kb_dir, ["recompile", "notes.md", "--all"])
-    assert "both" in result.output.lower() or "either" in result.output.lower() \
-        or result.exit_code != 0
+    with patch("openkb.agent.compiler.compile_short_doc", new_callable=AsyncMock) as short:
+        result = _invoke(kb_dir, ["recompile", "notes.md", "--all"])
+    assert "not both" in result.output.lower()
+    short.assert_not_called()
 
 
 def test_recompile_unknown_doc_friendly_error(kb_dir):
@@ -294,3 +298,17 @@ def test_recompile_no_refresh_schema_by_default(kb_dir):
     # Untouched without the flag
     assert agents.read_text(encoding="utf-8") == "OLD CUSTOM SCHEMA\n"
     assert not (kb_dir / "wiki" / "AGENTS.md.bak").exists()
+
+
+def test_recompile_refresh_schema_noop_when_agents_missing(kb_dir):
+    """Spec: --refresh-schema is a no-op when AGENTS.md is absent (runtime
+    already falls back to the bundled default), so nothing is written."""
+    _seed_short(kb_dir)
+    agents = kb_dir / "wiki" / "AGENTS.md"
+    agents.unlink(missing_ok=True)
+    with patch("openkb.agent.compiler.compile_short_doc", new_callable=AsyncMock) as short:
+        result = _invoke(kb_dir, ["recompile", "notes.md", "--refresh-schema"])
+
+    assert result.exit_code == 0, result.output
+    assert not agents.exists()  # not materialized
+    assert not (kb_dir / "wiki" / "AGENTS.md.bak").exists()