Refactor calling convention Rust API to allow default implementations · Vector35/binaryninja-api@ea82d20

error: this expression creates a reference which is immediately dereferenced by the compiler --> rust/src/types.rs:1268:45 | 1268 | let value_raw = Self::into_rust_raw(&self); | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_borrow

this expression creates a reference which is immediately dereferenced by the compiler: rust/src/types.rs#L1256

error: this expression creates a reference which is immediately dereferenced by the compiler --> rust/src/types.rs:1256:45 | 1256 | let value_raw = Self::into_rust_raw(&self); | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`

this lifetime isn't used in the function definition: rust/src/types.rs#L983

error: this lifetime isn't used in the function definition --> rust/src/types.rs:983:9 | 983 | 'a, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#extra_unused_lifetimes

this lifetime isn't used in the function definition: rust/src/types.rs#L932

error: this lifetime isn't used in the function definition --> rust/src/types.rs:932:21 | 932 | pub fn function<'a, T: Into<ReturnValue>>( | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#extra_unused_lifetimes

this lifetime isn't used in the function definition: rust/src/types.rs#L504

error: this lifetime isn't used in the function definition --> rust/src/types.rs:504:9 | 504 | 'a, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#extra_unused_lifetimes

this lifetime isn't used in the function definition: rust/src/types.rs#L452

error: this lifetime isn't used in the function definition --> rust/src/types.rs:452:21 | 452 | pub fn function<'a, T: Into<ReturnValue>>( | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#extra_unused_lifetimes = note: `-D clippy::extra-unused-lifetimes` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::extra_unused_lifetimes)]`

useless conversion to the same type: `binaryninjacore_sys::BNValueLocation`: rust/src/function.rs#L1116

error: useless conversion to the same type: `binaryninjacore_sys::BNValueLocation` --> rust/src/function.rs:1116:63 | 1116 | .for_each(|location| ValueLocation::free_rust_raw(location.into())); | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `location` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion

useless conversion to the same type: `types::ValueLocation`: rust/src/function.rs#L1102

error: useless conversion to the same type: `types::ValueLocation` --> rust/src/function.rs:1102:59 | 1102 | .map(|location| ValueLocation::into_rust_raw(&location.into())) | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `location` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion

useless conversion to the same type: `binaryninjacore_sys::BNValueLocation`: rust/src/function.rs#L1093

error: useless conversion to the same type: `binaryninjacore_sys::BNValueLocation` --> rust/src/function.rs:1093:63 | 1093 | .for_each(|location| ValueLocation::free_rust_raw(location.into())); | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `location` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion

useless conversion to the same type: `types::ValueLocation`: rust/src/function.rs#L1079

error: useless conversion to the same type: `types::ValueLocation` --> rust/src/function.rs:1079:59 | 1079 | .map(|location| ValueLocation::into_rust_raw(&location.into())) | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `location` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion = note: `-D clippy::useless-conversion` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`

typos

Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

cargo fmt

Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

cargo fmt: rust/src/function.rs#L515

Diff in /home/runner/work/binaryninja-api/binaryninja-api/rust/src/function.rs

cargo clippy

Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, clechasseur/rs-clippy-check@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

licensing

Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/upload-artifact@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

licensing

Failed to save: Unable to reserve cache with key cargo-install-cargo-about-0.6.6-8aef52bf1bd894d1c1c410ec, another job may be creating this cache.

licensing

Failed to restore:

licensing

New version for cargo-about available: 0.9.0