Skip to content

Rust bindings needed for custom function lifters #1522

Rust bindings needed for custom function lifters

Rust bindings needed for custom function lifters #1522

Triggered via pull request May 26, 2026 18:54
@zznopzznop
synchronize #8197
test_tms320c6x
Status Failure
Total duration 4m 25s
Artifacts 1

rust.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

11 errors and 6 warnings
cargo fmt
Process completed with exit code 1.
this expression creates a reference which is immediately dereferenced by the compiler: rust/src/types.rs#L1268
error: this expression creates a reference which is immediately dereferenced by the compiler --> rust/src/types.rs:1268:45 | 1268 | let value_raw = Self::into_rust_raw(&self); | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: rust/src/types.rs#L1256
error: this expression creates a reference which is immediately dereferenced by the compiler --> rust/src/types.rs:1256:45 | 1256 | let value_raw = Self::into_rust_raw(&self); | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
this lifetime isn't used in the function definition: rust/src/types.rs#L983
error: this lifetime isn't used in the function definition --> rust/src/types.rs:983:9 | 983 | 'a, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#extra_unused_lifetimes
this lifetime isn't used in the function definition: rust/src/types.rs#L932
error: this lifetime isn't used in the function definition --> rust/src/types.rs:932:21 | 932 | pub fn function<'a, T: Into<ReturnValue>>( | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#extra_unused_lifetimes
this lifetime isn't used in the function definition: rust/src/types.rs#L504
error: this lifetime isn't used in the function definition --> rust/src/types.rs:504:9 | 504 | 'a, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#extra_unused_lifetimes
this lifetime isn't used in the function definition: rust/src/types.rs#L452
error: this lifetime isn't used in the function definition --> rust/src/types.rs:452:21 | 452 | pub fn function<'a, T: Into<ReturnValue>>( | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#extra_unused_lifetimes = note: `-D clippy::extra-unused-lifetimes` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::extra_unused_lifetimes)]`
useless conversion to the same type: `binaryninjacore_sys::BNValueLocation`: rust/src/function.rs#L1117
error: useless conversion to the same type: `binaryninjacore_sys::BNValueLocation` --> rust/src/function.rs:1117:63 | 1117 | .for_each(|location| ValueLocation::free_rust_raw(location.into())); | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `location` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion
useless conversion to the same type: `types::ValueLocation`: rust/src/function.rs#L1103
error: useless conversion to the same type: `types::ValueLocation` --> rust/src/function.rs:1103:59 | 1103 | .map(|location| ValueLocation::into_rust_raw(&location.into())) | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `location` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion
useless conversion to the same type: `binaryninjacore_sys::BNValueLocation`: rust/src/function.rs#L1094
error: useless conversion to the same type: `binaryninjacore_sys::BNValueLocation` --> rust/src/function.rs:1094:63 | 1094 | .for_each(|location| ValueLocation::free_rust_raw(location.into())); | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `location` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion
useless conversion to the same type: `types::ValueLocation`: rust/src/function.rs#L1080
error: useless conversion to the same type: `types::ValueLocation` --> rust/src/function.rs:1080:59 | 1080 | .map(|location| ValueLocation::into_rust_raw(&location.into())) | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `location` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion = note: `-D clippy::useless-conversion` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
typos
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
cargo fmt
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
cargo fmt: rust/src/architecture.rs#L1776
Diff in /home/runner/work/binaryninja-api/binaryninja-api/rust/src/architecture.rs
cargo clippy
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, clechasseur/rs-clippy-check@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
licensing
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/upload-artifact@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
licensing
New version for cargo-about available: 0.9.0

Artifacts

Produced during runtime
Name Size Digest
license
29.3 KB
sha256:e0d8728475be08d30b8e2854e3acbe8be0976c943c2bd69a5f8aae6163d6405f