Skip to content

Commit 067252a

Browse files
xusheng6claude
andcommitted
[emulator] Move the public C++ API out of the BinaryNinja namespace
The plugin's LLILEmulator wrapper lived in namespace BinaryNinja, which is reserved for the core API. Move it to its own BinaryNinjaEmulatorAPI namespace, mirroring the debugger's BinaryNinjaDebuggerAPI. Addresses plafosse review comment on PR #8314. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent c6500c2 commit 067252a

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

plugins/emulator/api/emulatorapi.h

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,11 @@ limitations under the License.
2525
#include <utility>
2626
#include <vector>
2727

28-
namespace BinaryNinja
28+
using namespace BinaryNinja;
29+
30+
// The plugin's public C++ API lives in its own namespace (mirroring
31+
// BinaryNinjaDebuggerAPI) rather than in BinaryNinja, which is reserved for the core API.
32+
namespace BinaryNinjaEmulatorAPI
2933
{
3034
/*!
3135
\ingroup emulator
@@ -153,4 +157,4 @@ namespace BinaryNinja
153157
std::string SaveState() const;
154158
bool LoadState(const std::string& json);
155159
};
156-
} // namespace BinaryNinja
160+
} // namespace BinaryNinjaEmulatorAPI

plugins/emulator/api/ilemulator.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
#include "emulatorapi.h"
2424

2525
using namespace BinaryNinja;
26+
using namespace BinaryNinjaEmulatorAPI;
2627

2728

2829
LLILEmulator::LLILEmulator(Ref<BinaryView> view)

0 commit comments

Comments
 (0)