IDB Import refactor

Author: emesare

Cargo.lock

@@ -13,5 +13,7 @@ crate-type = ["cdylib"]
 anyhow = { version = "1.0.86", features = ["backtrace"] }
 binaryninja.workspace = true
 binaryninjacore-sys.workspace = true
-idb-rs = { git = "https://github.com/Vector35/idb-rs", tag = "0.1.12" }
-tracing = "0.1"
+idb-rs = { git = "https://github.com/Vector35/idb-rs", tag = "0.1.13" }
+tracing = "0.1"
+serde = { version = "1.0", features = ["derive"] }
+serde_json = "1.0"

plugins/idb_import/Cargo.toml

@@ -0,0 +1,42 @@
+use binaryninja::interaction::{Form, FormInputField};
+use std::path::PathBuf;
+
+pub mod load_file;
+
+pub struct LoadFileField {
+    filter: String,
+    default: Option<String>,
+}
+
+impl LoadFileField {
+    #[allow(unused)]
+    pub fn new(filter: &str) -> Self {
+        Self {
+            filter: filter.to_string(),
+            default: None,
+        }
+    }
+
+    pub fn with_default(filter: &str, default: &str) -> Self {
+        Self {
+            filter: filter.to_string(),
+            default: Some(default.to_string()),
+        }
+    }
+
+    pub fn field(&self) -> FormInputField {
+        FormInputField::OpenFileName {
+            prompt: "File Path".to_string(),
+            // TODO: This is called extension but is really a filter.
+            extension: Some(self.filter.clone()),
+            default: self.default.clone(),
+            value: None,
+        }
+    }
+
+    pub fn from_form(form: &Form) -> Option<PathBuf> {
+        let field = form.get_field_with_name("File Path")?;
+        let field_value = field.try_value_string()?;
+        Some(PathBuf::from(field_value))
+    }
+}

plugins/idb_import/src/addr_info.rs

@@ -0,0 +1,46 @@
+use crate::commands::LoadFileField;
+use crate::mapper::IDBMapper;
+use crate::parse::IDBFileParser;
+use binaryninja::binary_view::{BinaryView, BinaryViewExt};
+use binaryninja::command::Command;
+use binaryninja::interaction::Form;
+use std::fs::File;
+use std::io::BufReader;
+use std::path::PathBuf;
+
+pub struct LoadIDBFile;
+
+impl Command for LoadIDBFile {
+    fn action(&self, view: &BinaryView) {
+        let mut form = Form::new("Load IDB File");
+        let mut default_path = PathBuf::from(&view.file().file_path());
+        default_path.set_extension("idb");
+        let file_field =
+            LoadFileField::with_default("*.idb;;*.i64;;*.til", &default_path.to_string_lossy());
+        form.add_field(file_field.field());
+        if !form.prompt() {
+            return;
+        }
+        let Some(file_path) = LoadFileField::from_form(&form) else {
+            return;
+        };
+        let Ok(file) = File::open(&file_path) else {
+            tracing::error!("Failed to open file: {}", file_path.display());
+            return;
+        };
+        let mut file_reader = BufReader::new(file);
+        let file_parser = IDBFileParser::new();
+        match file_parser.parse(&mut file_reader) {
+            Ok(idb_info) => {
+                IDBMapper::new(idb_info).map_to_view(view);
+            }
+            Err(e) => {
+                tracing::error!("Failed to parse IDB file: {}", e);
+            }
+        }
+    }
+
+    fn valid(&self, _view: &BinaryView) -> bool {
+        true
+    }
+}