Rewrite Obj-C workflow in Rust

This is functionally equivalent to the previous workflow_objc, with the
following changes:
1. It mutates the `core.function.metaAnalysis` workflow rather than
   registering a new named workflow. The activities now all check for
   the presence of the Objective-C metadata added by `ObjCProcessor` to
   determine whether they should do work, rather than relying on
   `MachoView` to override the function workflow when Objective-C
   metadata is present. This fixes
   #6779.
2. The auto-inlining of `objc_msgSend` selector stub functions is
   performed in a separate activity from the processing of
   `objc_msgSend` call sites. The selector stub inlining activity is
   configured so that it does not run in `DSCView` as the shared cache
   needs different behavior for stub functions more generally that
   `SharedCacheWorkflow` already provides.
3. The way that types like `id` and `SEL` are referenced is fixed so
   that they show up as `id` rather than `objc_struct*`.

This also replaces the Objective-C portion of the shared cache's
workflow, and incorporates several bug fixes that had been applied to it
but not the standalone Objective-C workflow.

Author: bdash

Cargo.lock

@@ -16,9 +16,10 @@ members = [
     "plugins/idb_import",
     "plugins/pdb-ng",
     "plugins/pdb-ng/demo",
-    "plugins/warp", 
     "plugins/svd",
-    "plugins/svd/demo"
+    "plugins/svd/demo",
+    "plugins/warp",
+    "plugins/workflow_objc",
 ]
 
 [workspace.dependencies]

Cargo.toml

@@ -124,18 +124,18 @@ This repository contains all of our Binary View Type plugins available here:
 
 ## Other Plugins
 
-* [SVD Loader](https://github.com/Vector35/binaryninja-api/tree/dev/plugins/svd/)
+* [Objective-C](https://github.com/Vector35/binaryninja-api/tree/dev/plugins/workflow_objc/)
 * [RTTI Analysis](https://github.com/Vector35/binaryninja-api/tree/dev/plugins/rtti/)
-* [WARP Integration](https://github.com/Vector35/binaryninja-api/tree/dev/plugins/warp/)
 * [Stack Render Layer](https://github.com/Vector35/binaryninja-api/tree/dev/plugins/stack_render_layer/)
+* [SVD Loader](https://github.com/Vector35/binaryninja-api/tree/dev/plugins/svd/)
 * [Triage View](https://github.com/Vector35/binaryninja-api/tree/dev/examples/triage/)
+* [WARP Integration](https://github.com/Vector35/binaryninja-api/tree/dev/plugins/warp/)
 
 ## Related Repositories
 
-In addition to this main API repository being open source Vector35 also has open sourced the Debugger and the Objective-C plugins open source as well:
+In addition to this main API repository being open source Vector35 also has open sourced the Debugger plugin as well:
 
 * [Debugger](https://github.com/Vector35/debugger)
-* [workflow_objc](https://github.com/Vector35/workflow_objc)
 
 ## Licensing
 

README.md

@@ -1,35 +1,40 @@
 # Objective-C
 
-Binary Ninja ships with [an additional plugin](https://github.com/Vector35/workflow_objc) for assisting with Objective-C analysis. 
+Binary Ninja ships with built-in functionality for assisting with Objective-C analysis. 
 A brief summary of the features offered is as follows:
 
-- **Function Call Cleanup.** When using the Objective-C workflow, calls to
-  `objc_msgSend` can be replaced with direct calls to the relevant function's
-  implementation.
-
 - **Name and Type Recovery.** Using runtime information embedded in the
-  binary, Binary Ninja can automatically apply names and type information to
+  binary, Binary Ninja automatically applies names and type information to
   Objective-C functions.
 
 - **Structure Markup.** Data variables are automatically created for Objective-C
   structures such as classes and method lists to enable easy navigation.
 
-- **Data Renderers.** Formatting of Objective-C types such as tagged and/or
-  (image-)relative pointers is improved via custom data renderers.
+- **String Literal Handling.** Data variables are automatically created for all
+  `CFString` or `NSString` instances present in the binary.
 
-- **CFString Handling.** Data variables are automatically created for all
-  `CFString` instances present in the binary.
+- **Automatic Call Type Adjustments.** Binary Ninja automatically infers the number of arguments and their names
+  for individual calls to `objc_msgSend` and `objc_msgSendSuper2`. Argument names are derived from the selector
+  components, and argument types are inferred in limited cases.
 
-## Usage
+- **Pseudo Objective-C Language.** Decompiled code can be displayed using a _Pseudo Objective-C_
+  language syntax. This renders `objc_msgSend` and other Objective-C runtime calls using the
+  `[receiver message:argument other:argument2]` syntax found in Objective-C source code.
+  Additionally, literals such as `CFString` or `NSString` are displayed inline as `@"string"`.
 
-If you have an Objective-C binary opening in Binary Ninja should automatically process
-the information. This is handled by the view, e.g. MACH-O & Shared Cache.
+- **Direct Call Rewriting.** Calls to `objc_msgSend` can be rewritten to be direct calls to
+  the first known method implementation for that selector.
+  
+  This is disabled by default as it will give potentially confusing results for any selector
+  that has more than one implementation or for common selector names. That said, some users may
+  still find it to be useful. It can be enabled via `analysis.objectiveC.resolveDynamicDispatch`
+  setting.
+
+## Usage
 
-### Workflow
+Objective-C metadata will be automatically processed when you open a Mach-O or DYLD shared cache binary in Binary Ninja.
 
-To utilize function call cleanup, the Objective-C workflow must be chosen when loading a binary for analysis.
+The Pseudo Objective-C Language representation is available via the language pop-up menu at the top of Linear and Graph views:
 
-![](../img/objc-workflow-selected.png)
+![](../img/pseudo-objc-menu-item.png)
 
-This will automatically apply structure analysis as the binary is analyzed and
-also translate `objc_msgSend` calls to direct method calls, where possible.

docs/guide/objectivec.md

@@ -12,9 +12,9 @@ use binaryninja::background_task::BackgroundTask;
 use binaryninja::command::{
     register_command, register_command_for_function, register_command_for_project,
 };
+use binaryninja::is_ui_enabled;
 use binaryninja::logger::Logger;
 use binaryninja::settings::Settings;
-use binaryninja::{add_optional_plugin_dependency, is_ui_enabled};
 use log::LevelFilter;
 use reqwest::StatusCode;
 
@@ -200,9 +200,3 @@ pub extern "C" fn CorePluginInit() -> bool {
 
     true
 }
-
-#[unsafe(no_mangle)]
-pub extern "C" fn CorePluginDependencies() {
-    // TODO: Remove this once the objectivec workflow is registered on the meta workflow.
-    add_optional_plugin_dependency("workflow_objc");
-}