[ELF] Improve performance of loading binaries with many sections not mapped into the address space

bdash · bdash · commit 311be98aee14 · 2026-06-11T15:24:14.000-07:00
These sections are added to the parent view. Do the work within a bulk
segment modification to significantly reduce the overhead of adding
sections.
diff --git a/view/elf/elfview.cpp b/view/elf/elfview.cpp
@@ -615,6 +615,7 @@ bool ElfView::Init()
 	Elf64SectionHeader symbolTableSection;
 
 	BeginBulkAddSegments();
+	GetParentView()->BeginBulkAddSegments();
 	uint64_t segmentStart = 0;
 	for (size_t i = 1; i < m_elfSections.size(); i++)
 	{
@@ -736,6 +737,7 @@ bool ElfView::Init()
 		}
 	}
 
+	GetParentView()->EndBulkAddSegments();
 	EndBulkAddSegments();
 	// Apply architecture and platform
 	if (!m_arch)

Original file line number	Diff line number	Diff line change
`@@ -615,6 +615,7 @@ bool ElfView::Init()`
`615`	`615`	`Elf64SectionHeader symbolTableSection;`
`616`	`616`
`617`	`617`	`BeginBulkAddSegments();`
	`618`	`+ GetParentView()->BeginBulkAddSegments();`
`618`	`619`	`uint64_t segmentStart = 0;`
`619`	`620`	`for (size_t i = 1; i < m_elfSections.size(); i++)`
`620`	`621`	`{`
`@@ -736,6 +737,7 @@ bool ElfView::Init()`
`736`	`737`	`}`
`737`	`738`	`}`
`738`	`739`
	`740`	`+ GetParentView()->EndBulkAddSegments();`
`739`	`741`	`EndBulkAddSegments();`
`740`	`742`	`// Apply architecture and platform`
`741`	`743`	`if (!m_arch)`