Build C-style format provider as a core plugin

Author: plafosse

binaryninjaapi.cpp

@@ -19,21 +19,11 @@
 // IN THE SOFTWARE.
 
 #include "binaryninjaapi.h"
-#include "cstyleformatstringresolutionprovider.h"
 #include <numeric>
 
 using namespace BinaryNinja;
 using namespace std;
 
-namespace
-{
-	const bool g_cStyleFormatStringResolutionProviderRegistered = []() {
-		RegisterCStyleFormatStringResolutionProvider();
-		return true;
-	}();
-}
-
-
 struct WorkerThreadActionContext
 {
 	std::function<void()> action;

plugins/cstyle_format_string/CMakeLists.txt

@@ -0,0 +1,44 @@
+cmake_minimum_required(VERSION 3.15 FATAL_ERROR)
+
+project(cstyle_format_string)
+
+file(GLOB SOURCES CONFIGURE_DEPENDS
+        *.cpp
+        *.c
+        *.h)
+
+if(DEMO)
+    add_library(${PROJECT_NAME} STATIC ${SOURCES})
+else()
+    add_library(${PROJECT_NAME} SHARED ${SOURCES})
+endif()
+
+if(NOT BN_INTERNAL_BUILD)
+    # Out-of-tree build
+    find_path(
+            BN_API_PATH
+            NAMES binaryninjaapi.h
+            HINTS ../../.. binaryninjaapi $ENV{BN_API_PATH}
+            REQUIRED
+    )
+    add_subdirectory(${BN_API_PATH} api)
+endif()
+
+target_link_libraries(${PROJECT_NAME} binaryninjaapi)
+
+set_target_properties(${PROJECT_NAME} PROPERTIES
+        CXX_STANDARD 20
+        CXX_VISIBILITY_PRESET hidden
+        CXX_STANDARD_REQUIRED ON
+        C_VISIBILITY_PRESET hidden
+        VISIBILITY_INLINES_HIDDEN ON
+        POSITION_INDEPENDENT_CODE ON)
+
+if(BN_INTERNAL_BUILD)
+    plugin_rpath(${PROJECT_NAME})
+    set_target_properties(${PROJECT_NAME} PROPERTIES
+            LIBRARY_OUTPUT_DIRECTORY ${BN_CORE_PLUGIN_DIR}
+            RUNTIME_OUTPUT_DIRECTORY ${BN_CORE_PLUGIN_DIR})
+else()
+    bn_install_plugin(${PROJECT_NAME})
+endif()

plugins/cstyle_format_string/plugin.cpp

@@ -0,0 +1,18 @@
+#include "cstyleformatstringresolutionprovider.h"
+
+using namespace BinaryNinja;
+
+extern "C"
+{
+	BN_DECLARE_CORE_ABI_VERSION
+
+#ifdef DEMO_EDITION
+	bool CStyleFormatStringPluginInit()
+#else
+	BINARYNINJAPLUGIN bool CorePluginInit()
+#endif
+	{
+		RegisterCStyleFormatStringResolutionProvider();
+		return true;
+	}
+}