Skip to content

Commit 36a54eb

Browse files
committed
fixup! Migrate remaining demangler consumers
1 parent 603fe85 commit 36a54eb

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

view/sharedcache/workflow/SharedCacheWorkflow.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@ void IdentifyStub(BinaryView& view, const SharedCacheController& controller, con
9999
std::string demangledName = symbol->name;
100100
if (auto result = Demangler::DemangleAny(symbol->name, demanglerConfig))
101101
demangledName = result->name.GetString();
102+
// TODO: The demangled type here is almost always wrong so we omit it for now.
102103
auto rawName = STUB_PREFIX + symbol->name;
103104
auto shortName = STUB_PREFIX + demangledName;
104105

@@ -107,6 +108,8 @@ void IdentifyStub(BinaryView& view, const SharedCacheController& controller, con
107108
{
108109
// NOTE: The type library name is expected to be the image name currently.
109110
// Try and pull the type from the associated type library (if there is one)
111+
// TODO: The demangled type here is missing a param.
112+
// Ref<Type> selectedType = demangledType;
110113
Ref<Type> selectedType = nullptr;
111114
if (const auto image = controller.GetImageContaining(symbolAddr))
112115
{

0 commit comments

Comments
 (0)