Skip to content

Commit 4963e1d

Browse files
committed
Change enterprise server version from string to VersionInfo struct
1 parent af50b06 commit 4963e1d

3 files changed

Lines changed: 11 additions & 7 deletions

File tree

binaryninjaapi.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22532,7 +22532,7 @@ namespace BinaryNinja::Collaboration
2253222532
std::string GetUsername();
2253322533
std::string GetToken();
2253422534
int GetServerVersion();
22535-
std::string GetServerBuildVersion();
22535+
VersionInfo GetServerBuildVersion();
2253622536
std::string GetServerBuildId();
2253722537
std::vector<std::pair<std::string, std::string>> GetAuthBackends();
2253822538
bool HasPulledProjects();

binaryninjacore.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8582,7 +8582,7 @@ extern "C"
85828582
BINARYNINJACOREAPI char* BNRemoteGetUsername(BNRemote* remote);
85838583
BINARYNINJACOREAPI char* BNRemoteGetToken(BNRemote* remote);
85848584
BINARYNINJACOREAPI int BNRemoteGetServerVersion(BNRemote* remote);
8585-
BINARYNINJACOREAPI char* BNRemoteGetServerBuildVersion(BNRemote* remote);
8585+
BINARYNINJACOREAPI BNVersionInfo BNRemoteGetServerBuildVersion(BNRemote* remote);
85868586
BINARYNINJACOREAPI char* BNRemoteGetServerBuildId(BNRemote* remote);
85878587
BINARYNINJACOREAPI bool BNRemoteGetAuthBackends(BNRemote* remote, char*** backendIds, char*** backendNames, size_t* count);
85888588
BINARYNINJACOREAPI bool BNRemoteHasPulledProjects(BNRemote* remote);

collaboration.cpp

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -632,11 +632,15 @@ int Remote::GetServerVersion()
632632
}
633633

634634

635-
std::string Remote::GetServerBuildVersion()
636-
{
637-
char* buildVersion = BNRemoteGetServerBuildVersion(m_object);
638-
std::string result = buildVersion;
639-
BNFreeString(buildVersion);
635+
VersionInfo Remote::GetServerBuildVersion()
636+
{
637+
BNVersionInfo bnVersion = BNRemoteGetServerBuildVersion(m_object);
638+
VersionInfo result;
639+
result.major = bnVersion.major;
640+
result.minor = bnVersion.minor;
641+
result.build = bnVersion.build;
642+
result.channel = bnVersion.channel;
643+
BNFreeString(bnVersion.channel);
640644
return result;
641645
}
642646

0 commit comments

Comments
 (0)