Propegate nullptr on Repository::GetPluginByPath

0cyn · 0cyn · commit 65582278e36d · 2026-04-15T12:19:40.000-04:00
diff --git a/pluginmanager.cpp b/pluginmanager.cpp
@@ -352,7 +352,10 @@ vector<Ref<Extension>> Repository::GetPlugins() const
 
 Ref<Extension> Repository::GetPluginByPath(const string& pluginPath)
 {
-	return new Extension(BNRepositoryGetPluginByPath(m_object, pluginPath.c_str()));
+	BNPlugin* plugin = BNRepositoryGetPluginByPath(m_object, pluginPath.c_str());
+	if (!plugin)
+		return nullptr;
+	return new Extension(plugin);
 }
 
 string Repository::GetFullPath() const

Original file line number	Diff line number	Diff line change
`@@ -352,7 +352,10 @@ vector<Ref<Extension>> Repository::GetPlugins() const`
`352`	`352`
`353`	`353`	`Ref<Extension> Repository::GetPluginByPath(const string& pluginPath)`
`354`	`354`	`{`
`355`		`- return new Extension(BNRepositoryGetPluginByPath(m_object, pluginPath.c_str()));`
	`355`	`+ BNPlugin* plugin = BNRepositoryGetPluginByPath(m_object, pluginPath.c_str());`
	`356`	`+ if (!plugin)`
	`357`	`+ return nullptr;`
	`358`	`+ return new Extension(plugin);`
`356`	`359`	`}`
`357`	`360`
`358`	`361`	`string Repository::GetFullPath() const`