[emulator] Start EmuRefCountObject at a reference count of 1

The reference-counted base started at 0 and relied on the create helper's
AddAPIRef to reach 1, leaving the object destructible by any transient
AddRef/Release during construction. Start at 1 (the birth reference handed to
the creator) like core's RefCountObject, and have the create helper hand off
that reference without an extra AddRef.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: xusheng6

plugins/emulator/core/llilemulator.cpp

@@ -3583,13 +3583,13 @@ bool LLILEmulator::StubFread(uint64_t)
 
 BNLLILEmulator* BNCreateLLILEmulatorForView(BNBinaryView* view)
 {
-	return EMU_API_OBJECT_REF(new LLILEmulator(new BinaryView(BNNewViewReference(view))));
+	return EMU_API_OBJECT_CREATE(new LLILEmulator(new BinaryView(BNNewViewReference(view))));
 }
 
 
 BNLLILEmulator* BNCreateLLILEmulator(BNLowLevelILFunction* il, BNBinaryView* view)
 {
-	return EMU_API_OBJECT_REF(new LLILEmulator(new LowLevelILFunction(BNNewLowLevelILFunctionReference(il)), new BinaryView(BNNewViewReference(view))));
+	return EMU_API_OBJECT_CREATE(new LLILEmulator(new LowLevelILFunction(BNNewLowLevelILFunctionReference(il)), new BinaryView(BNNewViewReference(view))));
 }
 
 

plugins/emulator/core/refcountobject.h

@@ -27,7 +27,10 @@ namespace BinaryNinjaEmulator
 	{
 	public:
 		std::atomic<int> m_refs;
-		EmuRefCountObject() : m_refs(0) {}
+		// Born with one reference (the one handed to whoever creates the object), mirroring
+		// core's RefCountObject. Starting at 0 would leave the object destructible by any
+		// transient AddRef/Release that happens before the creator takes its reference.
+		EmuRefCountObject() : m_refs(1) {}
 		virtual ~EmuRefCountObject() {}
 
 		void AddRef() { m_refs.fetch_add(1); }
@@ -44,12 +47,13 @@ namespace BinaryNinjaEmulator
 
 
 	// Macro-like helpers to hand referenced objects across the external C ABI.
+	// Hand a freshly-created object's birth reference to the caller (no extra AddRef; the
+	// object is constructed with a reference count of 1).
 	template <class T>
-	static typename T::APIHandle EMU_API_OBJECT_REF(T* obj)
+	static typename T::APIHandle EMU_API_OBJECT_CREATE(T* obj)
 	{
 		if (obj == nullptr)
 			return nullptr;
-		obj->AddAPIRef();
 		return obj->GetAPIObject();
 	}