[emulator] Move intx include out of binaryninjaapi.h into emulator headers

binaryninjaapi.h does not provide the emulator API, so the wide-integer
type it pulls in for the plugin does not belong there. Move the (windows.h
min/max-guarded) intx include into a shared emulator_intx.h included by the
emulator's own core and API roots instead.

Addresses review feedback on PR #8314.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: xusheng6

binaryninjaapi.h

@@ -31,23 +31,6 @@
 #include "binaryninjacore.h"
 #include "exceptions.h"
 
-// intx provides the wide-integer type used by the emulator plugin's API. If a
-// translation unit includes <windows.h> before this header (as several debugger
-// adapters do), its min/max macros would break intx's numeric_limits<>::min()/max()
-// member definitions. Neutralize those macros just for the intx include, then
-// restore them so any later code that relies on windows.h min/max is unaffected.
-#if defined(_WIN32)
-	#pragma push_macro("min")
-	#pragma push_macro("max")
-	#undef min
-	#undef max
-#endif
-#include "vendor/intx/intx.hpp"
-#if defined(_WIN32)
-	#pragma pop_macro("min")
-	#pragma pop_macro("max")
-#endif
-
 #include "json/json.h"
 #include "rapidjsonwrapper.h"
 #include "vendor/nlohmann/json.hpp"

plugins/emulator/api/emulator_intx.h

@@ -0,0 +1,36 @@
+/*
+Copyright 2020-2026 Vector 35 Inc.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+#pragma once
+
+// intx provides the wide-integer type used throughout the emulator plugin's core and
+// API. It lives here (rather than in binaryninjaapi.h) so it is only pulled in by the
+// emulator's own headers. If a translation unit includes <windows.h> before this header
+// (as several debugger adapters do), its min/max macros would break intx's
+// numeric_limits<>::min()/max() member definitions. Neutralize those macros just for the
+// intx include, then restore them so any later code relying on windows.h min/max is
+// unaffected.
+#if defined(_WIN32)
+	#pragma push_macro("min")
+	#pragma push_macro("max")
+	#undef min
+	#undef max
+#endif
+#include "vendor/intx/intx.hpp"
+#if defined(_WIN32)
+	#pragma pop_macro("min")
+	#pragma pop_macro("max")
+#endif

plugins/emulator/api/emulatorapi.h

@@ -17,6 +17,7 @@ limitations under the License.
 #pragma once
 
 #include "binaryninjaapi.h"
+#include "emulator_intx.h"
 #include "ffi.h"
 #include <functional>
 #include <string>

plugins/emulator/core/ilemulator.h

@@ -1,6 +1,7 @@
 #pragma once
 
 #include "binaryninjaapi.h"
+#include "../api/emulator_intx.h"
 #include "ffi_global.h"
 #include "refcountobject.h"
 #include <atomic>