[CMake] Specify CONFIGURE_DEPENDS for all file(GLOB ...)#7200
Merged
Conversation
CouleeApps
approved these changes
Jul 29, 2025
CouleeApps
left a comment
CouleeApps
left a comment
Member
There was a problem hiding this comment.
Looks good in this repo. We should do the same in the various other repos (core, debugger, etc)
Contributor
Author
|
Yeah, I have corresponding changes prepared for the other repositories. |
This ensures that CMake detects when files that match the glob are added or removed.
bdash
force-pushed
the
cmake-glob-configure-depends
branch
from
82efb9a to
42878c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that CMake detects when files that match the glob are added or removed.