update idb_import idb-rs to 0.1.12

[rbran]

Unfortunately I'm unable to test this on the latest dev release of Binary Ninja, it seems that something on the BinaryViewReader changed (likely BinaryView::offset_valid) and it broke all the versions of idb_import.

I'm investigating.

[rbran]

Seems like self.bv.offset_valid(offset) was returning true if offset = [the file size] previously, but now it returns false.

[emesare]

We added a reader / writer impl recently in the rust bindings, maybe those work? I recall you asking for them @rbran

binaryninja-api/rust/src/binary_view/reader.rs

Lines 101 to 138 in cde1c38

	impl Seek for BinaryReader {
	/// Seek to the specified position.
	fn seek(&mut self, pos: SeekFrom) -> std::io::Result<u64> {
	match pos {
	SeekFrom::Current(offset) => self.seek_to_relative_offset(offset),
	SeekFrom::Start(offset) => self.seek_to_offset(offset),
	SeekFrom::End(end_offset) => {
	// We do NOT need to add the image base here as
	// the reader (unlike the writer) can set the virtual base.
	let offset =
	self.view
	.len()
	.checked_add_signed(end_offset)
	.ok_or(std::io::Error::new(
	ErrorKind::Other,
	"Seeking from end overflowed",
	))?;
	self.seek_to_offset(offset);
	}
	};
	Ok(self.offset())
	}
	}
	impl Read for BinaryReader {
	fn read(&mut self, buf: &mut [u8]) -> std::io::Result<usize> {
	let len = buf.len();
	let result = unsafe { BNReadData(self.handle, buf.as_mut_ptr() as *mut _, len) };
	if !result {
	Err(std::io::Error::new(ErrorKind::Other, "Read out of bounds"))
	} else {
	Ok(len)
	}
	}
	}

https://github.com/Vector35/binaryninja-api/blob/dev/rust/tests/binary_reader.rs

[rbran]

Humm...

I forgot about that, that wold had worked too.

[emesare]

binaryninja-api/rust/src/binary_view/reader.rs

Lines 101 to 138 in cde1c38

	impl Seek for BinaryReader {
	/// Seek to the specified position.
	fn seek(&mut self, pos: SeekFrom) -> std::io::Result<u64> {
	match pos {
	SeekFrom::Current(offset) => self.seek_to_relative_offset(offset),
	SeekFrom::Start(offset) => self.seek_to_offset(offset),
	SeekFrom::End(end_offset) => {
	// We do NOT need to add the image base here as
	// the reader (unlike the writer) can set the virtual base.
	let offset =
	self.view
	.len()
	.checked_add_signed(end_offset)
	.ok_or(std::io::Error::new(
	ErrorKind::Other,
	"Seeking from end overflowed",
	))?;
	self.seek_to_offset(offset);
	}
	};
	Ok(self.offset())
	}
	}
	impl Read for BinaryReader {
	fn read(&mut self, buf: &mut [u8]) -> std::io::Result<usize> {
	let len = buf.len();
	let result = unsafe { BNReadData(self.handle, buf.as_mut_ptr() as *mut _, len) };
	if !result {
	Err(std::io::Error::new(ErrorKind::Other, "Read out of bounds"))
	} else {
	Ok(len)
	}
	}
	}

As per the discussion we had in this PR swap BinaryViewReader out for the one in bindings

[rbran]

I'm unable to use BinaryReader, I get a io error: Read out of bounds

[emesare]

Merged with 8d4fcf6 apologies for the delay!