[DSC] Add support for DriverKit shared caches#7265
Merged
Merged
Conversation
Contributor
|
lgtm! iOS/mac platform differentiation primarily matters for type libraries; if the DriverKit libraries are importing public frameworks and the function signatures may differ between platforms then it could cause decomp issues. Otherwise this is ok for now. |
Contributor
Author
|
The image paths are all prefixed with /System/DriverKit so I think neither Mac nor iOS type libraries will match at the moment. |
0cyn
approved these changes
Aug 14, 2025
Contributor
Author
|
This is available in 5.2.8119 and newer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared cache files use the same DriverKit platform value for both Mac and iOS. I opted to map them both to a Mac platform for now. It seems to work fine in my testing with both Mac and iOS caches. Is this likely to cause any problems?