Skip to content

[RTTI] Fix Itanium RTTI scan failing to symbolize objects with extern typeinfo #8082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emesare wants to merge 1 commit into
base: dev
Choose a base branch
from
+5 −3
Open

[RTTI] Fix Itanium RTTI scan failing to symbolize objects with extern typeinfo #8082

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions plugins/rtti/itanium.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,9 +446,11 @@ std::optional<ClassInfo> ItaniumRTTIProcessor::ProcessRTTI(uint64_t objectAddr)
return std::nullopt;
auto symName = sym->GetShortName();
// Remove type info prefix.
if (symName.rfind("_typeinfo_for_", 0) != 0)
return std::nullopt;
return symName.substr(14);
if (symName.rfind("_typeinfo_for_", 0) == 0)
return symName.substr(14);
if (symName.rfind("typeinfo_for_", 0) == 0)
return symName.substr(13);
return std::nullopt;
};

if (typeInfoVariant == TIVSIClass)
Expand Down