Skip to content

[Rust] Allow configuring API path for cargo builds #8254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ninja3047 wants to merge 1 commit into
base: dev
Choose a base branch
from
+28 −11
Open

[Rust] Allow configuring API path for cargo builds #8254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 28 additions & 11 deletions rust/binaryninjacore-sys/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,16 +41,22 @@ fn link_path() -> PathBuf {
})
}

fn api_base_path() -> PathBuf {
env::var_os("BINARYNINJA_API_DIR")
.map(PathBuf::from)
.unwrap_or_else(|| {
let manifest_dir =
std::env::var("CARGO_MANIFEST_DIR").expect("CARGO_MANIFEST_DIR not set");
std::path::PathBuf::from(manifest_dir)
.join("../../")
.canonicalize()
.unwrap()
})
}

// Generate and compile stub shared library and return the path to the folder containing the built stub library
fn generate_stubs() -> PathBuf {
let manifest_dir = std::env::var("CARGO_MANIFEST_DIR").expect("CARGO_MANIFEST_DIR not set");

let api_base_path = std::path::PathBuf::from(manifest_dir)
.join("../../")
.canonicalize()
.unwrap();

let stubs_path = api_base_path.join("stubs");
let stubs_path = api_base_path().join("stubs");

// TODO: does visual studio add the config name as a subdirectory?
cmake::Config::new(stubs_path)
Expand All @@ -61,7 +67,13 @@ fn generate_stubs() -> PathBuf {

fn main() {
println!("cargo:rerun-if-env-changed=BINARYNINJADIR");
println!("cargo:rerun-if-changed=../../binaryninjacore.h");
println!("cargo:rerun-if-env-changed=BINARYNINJA_API_DIR");

let api_base_path = api_base_path();
println!(
"cargo:rerun-if-changed={}",
api_base_path.join("binaryninjacore.h").display()
);

//Cargo's output directory
let out_dir = env::var("OUT_DIR").unwrap();
Expand Down Expand Up @@ -97,7 +109,7 @@ fn main() {
let minimum_line = "#define BN_MINIMUM_UI_ABI_VERSION ";
let mut current_version = "0".to_string();
let mut minimum_version = "0".to_string();
let file = File::open("../../ui/uitypes.h").expect("Couldn't open uitypes.h");
let file = File::open(api_base_path.join("ui/uitypes.h")).expect("Couldn't open uitypes.h");
for line in BufReader::new(file).lines() {
let line = line.unwrap();
if let Some(version) = line.strip_prefix(current_line) {
Expand All @@ -108,7 +120,12 @@ fn main() {
}

bindgen::builder()
.header("../../binaryninjacore.h")
.header(
api_base_path
.join("binaryninjacore.h")
.to_string_lossy()
.into_owned(),
)
.clang_arg("-std=c++20")
.clang_arg("-x")
.clang_arg("c++")
Expand Down