[armv7] Implement IsELFDataRelocation more efficiently#8262
Merged
Conversation
fuzyll
approved these changes
Jun 12, 2026
fuzyll
left a comment
fuzyll
left a comment
Contributor
There was a problem hiding this comment.
Good find! I'm not really sure why this was written that way. I also wouldn't have immediately realized this was a performance problem if it hadn't come up in the context of the user's issue today.
...which, as far as I can tell, has been completely backwards since this code was shipped.
…mapped into the address space These sections are added to the parent view. Do the work within a bulk segment modification to significantly reduce the overhead of adding sections.
There's no reason for these to create `std::map`s when a switch does the trick.
fuzyll
force-pushed
the
test_armv7_is_elf_data_reloc
branch
from
432a587 to
01ab3ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no reason for these to create
std::maps when a switch does the trick.