Skip to content

[ELF] Improve performance of loading binaries with many sections not mapped into the address space #8263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fuzyll merged 2 commits into from
Jun 12, 2026
+7 −5
Merged

[ELF] Improve performance of loading binaries with many sections not mapped into the address space #8263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0e0b93
Fix MSP430 default calling convention.
fuzyll Jun 12, 2026
9916086
[ELF] Improve performance of loading binaries with many sections not …
bdash Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions arch/msp430/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,14 @@ pub extern "C" fn CorePluginInit() -> bool {
// standardized one that is compatible with TI's compiler
let default = calling_convention::ConventionBuilder::new(arch)
.is_eligible_for_heuristics(true)
.int_arg_registers(&["r15", "r14", "r13", "r12"])
.return_int_reg("r15")
.return_hi_int_reg("r14")
.int_arg_registers(&["r12", "r13", "r14", "r15"])
.return_int_reg("r12")
.return_hi_int_reg("r13")
.register("default");
calling_convention::ConventionBuilder::new(arch)
.is_eligible_for_heuristics(true)
.return_int_reg("r15")
.return_hi_int_reg("r14")
.return_int_reg("r12")
.return_hi_int_reg("r13")
.register("stack");

arch.set_default_calling_convention(&default);
Expand Down
2 changes: 2 additions & 0 deletions view/elf/elfview.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,6 +615,7 @@ bool ElfView::Init()
Elf64SectionHeader symbolTableSection;

BeginBulkAddSegments();
GetParentView()->BeginBulkAddSegments();
uint64_t segmentStart = 0;
for (size_t i = 1; i < m_elfSections.size(); i++)
{
Expand Down Expand Up @@ -736,6 +737,7 @@ bool ElfView::Init()
}
}

GetParentView()->EndBulkAddSegments();
EndBulkAddSegments();
// Apply architecture and platform
if (!m_arch)
Expand Down
Loading