Binary view and DebuggerController leaks in race condition

[xusheng6]

DebuggerController::GetController: creating controller for file 0xbcbf4e310
DebuggerController::DeleteController(0xbcbf4e310): found? true
DebuggerController::GetController: creating controller for file 0xbcbf4e310

It can be triggered in cases as simple as just launching the target and then kill it, but it does not repro reliably

I have seen sth before -- when we close the tab and everything is being teared down, the controller is properly deleted. However, something else (presumably a UI widget that is not deleted yet) asks a new controller to be created for the binary, and that controller never gets deleted

[xusheng6]

Similar to #641

[bdash]

DebuggerController::GetController: creating controller for file 0xb6b18b9d0
DebuggerController::DeleteController(0xb6b18b9d0): found? true
DebuggerController::GetController: creating controller for file 0xb6b18b9d0
0   libdebuggercore.dylib               0x000000010edc2250 BinaryNinjaDebugger::DebuggerController::GetController(BinaryNinja::Ref<BinaryNinja::BinaryView>) + 408
1   libdebuggercore.dylib               0x000000010edea104 BNGetDebuggerController + 204
2   libdebuggerui.dylib                 0x0000000133228e14 BinaryNinjaDebuggerAPI::DebuggerController::GetController(BinaryNinja::Ref<BinaryNinja::BinaryView>) + 36
3   libdebuggerui.dylib                 0x0000000133216d18 std::__1::__function::__func<GlobalDebuggerUI::SetupMenu(UIContext*)::$_3, bool (UIActionContext const&)>::operator()(UIActionContext const&) + 104
4   libbinaryninjaui.1.dylib            0x0000000102ab6db4 MenuInstance::update(UIActionHandler*, UIActionContext const&, bool) + 1228
5   libbinaryninjaui.1.dylib            0x0000000102aba2d0 MainMenuInstance::update(UIActionHandler*, UIActionContext const&) + 588
6   libbinaryninjaui.1.dylib            0x0000000102aba054 MainMenuInstance::update(UIActionHandler*) + 200
7   binaryninja                         0x00000001001036b4 MainWindow::updateAllMenuStates() + 64
8   binaryninja                         0x00000001000a1aa8 BinaryNinjaApplication::focusChangedEvent(QWidget*, QWidget*) + 36
9   QtCore                              0x0000000102368ef0 void doActivate<false>(QObject*, int, void**) + 1404
10  QtWidgets                           0x0000000103be66c0 QApplicationPrivate::setFocusWidget(QWidget*, Qt::FocusReason) + 552
11  QtWidgets                           0x0000000103c2fae8 QWidget::setFocus(Qt::FocusReason) + 604
12  QtWidgets                           0x0000000103c3002c QWidget::focusNextPrevChild(bool) + 284
13  QtWidgets                           0x0000000103c34508 QWidgetPrivate::hide_helper() + 376
14  QtWidgets                           0x0000000103c35474 QWidgetPrivate::setVisible(bool) + 1048
15  QtWidgets                           0x0000000103c34e0c QWidget::setVisible(bool) + 780
16  QtWidgets                           0x0000000103c1a388 QStackedLayout::setCurrentIndex(int) + 364
17  libbinaryninjaui.1.dylib            0x0000000102dec24c SidebarWidgetContainer::activate(SidebarWidgetType*) + 396
18  libbinaryninjaui.1.dylib            0x0000000102debb44 SidebarWidgetContainer::setActiveContext(SplitPaneWidget*, QString const&) + 304
19  libbinaryninjaui.1.dylib            0x0000000102ddc5b8 Sidebar::forAllContainers(std::__1::function<void (SidebarWidgetContainer*)> const&) const + 64
20  libbinaryninjaui.1.dylib            0x0000000102ddf328 Sidebar::setActiveContext(SplitPaneWidget*, ViewFrame*, QString const&, BinaryNinja::Ref<BinaryNinja::BinaryView>) + 1564
21  libbinaryninjaui.1.dylib            0x0000000102ddfb7c Sidebar::destroyContext(ViewFrame*) + 148
22  libbinaryninjaui.1.dylib            0x0000000102d42f38 std::__1::__function::__func<SplitPaneContainer::enumerateViewPanes(std::__1::function<void (ViewPane*)> const&)::$_0, void (Pane*)>::operator()(Pane*&&) + 72
23  libbinaryninjaui.1.dylib            0x0000000102d330c4 SplitPaneContainer::enumeratePanes(std::__1::function<void (Pane*)> const&) + 60
24  libbinaryninjaui.1.dylib            0x0000000102d40a2c SplitPaneWidget::enumerateViewPanes(std::__1::function<void (ViewPane*)> const&) + 64
25  binaryninja                         0x00000001000fc414 MainWindow::tabCloseInternal(DockableTabWidget*, int) + 1384
26  binaryninja                         0x00000001000fa76c MainWindow::tabCloseRequested(DockableTabWidget*, int, bool) + 228

[xusheng6]

This might be related to #546 and https://github.com/Vector35/binaryninja/pull/650

[xusheng6]

This a regression:

debugger/ui/ui.cpp

Line 350 in f4c7e1c

// The reason why we must avoid creating a new debugger controller here is because these enable callbacks

[xusheng6]

See https://github.com/Vector35/binaryninja/issues/502 for details

[xusheng6]

Closed by accident