add smoke test

Author: nerdai

examples/nnunet_pfl_example/client.py

@@ -4,7 +4,7 @@
 from logging import DEBUG, INFO
 from os.path import exists, join
 from pathlib import Path
-from typing import Any, Literal
+from typing import Any
 
 from fl4health.checkpointing.client_module import ClientCheckpointAndStateModule
 from fl4health.checkpointing.state_checkpointer import ClientStateCheckpointer
@@ -45,7 +45,7 @@ def main(
     compile: bool = True,
     intermediate_client_state_dir: str | None = None,
     client_name: str | None = None,
-    personalized_strategy: Literal["ditto"] | None = None,
+    personalized_strategy: str = "ditto",
 ) -> None:
     with torch.autograd.set_detect_anomaly(True):
         # Log device and server address
@@ -103,7 +103,7 @@ def main(
             checkpoint_and_state_module=checkpoint_and_state_module,
             client_name=client_name,
         )
-        if personalized_strategy:
+        if personalized_strategy in personalized_client_classes:
             log(INFO, f"Setting up client for personalized strategy: {personalized_strategy}")
             client = personalized_client_classes[personalized_strategy](**client_kwargs)
         else:
@@ -211,9 +211,9 @@ def main(
         "--personalized-strategy",
         type=str,
         required=False,
-        default=None,
+        default="ditto",
         help="[OPTIONAL] Personalized strategy to use. For now, can only be 'ditto'. \
-        Defaults to None, in which no personalized strategy is applied.",
+        Defaults to 'ditto', in which no personalized strategy is applied.",
     )
     parser.add_argument(
         "--seed",

tests/smoke_tests/test_smoke_tests.py

@@ -463,3 +463,18 @@ async def test_flexible_nnunet_config_3d(tolerance: float) -> None:
     task = asyncio.create_task(coroutine)
     await try_running_test_task(task)
     assert_on_done_task(task)
+
+
+@pytest.mark.smoketest
+async def test_ditto_flexible_nnunet_config_2d(tolerance: float) -> None:
+    coroutine = run_smoke_test(  # By default will use Task04_Hippocampus Dataset
+        server_python_path="examples.nnunet_pfl_example.server",
+        client_python_path="examples.nnunet_pfl_example.client",
+        config_path="tests/smoke_tests/nnunet_config_2d.yaml",
+        dataset_path="examples/datasets/nnunet",
+        tolerance=tolerance,
+        read_logs_timeout=450,
+    )
+    task = asyncio.create_task(coroutine)
+    await try_running_test_task(task)
+    assert_on_done_task(task)