Fixing typing annotation in Bernoulli sample#395
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #395 +/- ##
=======================================
Coverage 76.81% 76.81%
=======================================
Files 155 155
Lines 9464 9464
=======================================
Hits 7270 7270
Misses 2194 2194 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lotif
reviewed
Jun 4, 2025
lotif
approved these changes
Jun 4, 2025
lotif
left a comment
lotif
left a comment
Collaborator
There was a problem hiding this comment.
Approved, but I just noticed this is a draft PR?
fatemetkl
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Fix
Short Description
Quick fix to typing annotation in the
BernoulliSampleclass ofutils/functions.pyas reported in Issue #393Tests Added
None, it's a mypy typing thing, so doesn't affect actual code flow.