Skip to content

Fixing typing annotation in Bernoulli sample #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emersodb merged 2 commits into from
Jun 4, 2025
Merged

Fixing typing annotation in Bernoulli sample #395

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
baf6d9e
Fixing typing annotation in Bernoulli sample
emersodb Jun 4, 2025
4f25c07
Removing the type ignores
emersodb Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fl4health/utils/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class BernoulliSample(torch.autograd.Function):
"""

@staticmethod
def forward(bernoulli_probs: torch.Tensor) -> torch.Tensor: # type: ignore
def forward(bernoulli_probs: torch.Tensor) -> torch.Tensor:
return torch.bernoulli(input=bernoulli_probs)

@staticmethod
Expand All @@ -33,7 +33,7 @@ def setup_context(ctx: Any, inputs: tuple[torch.Tensor], output: torch.Tensor) -
# This method determines the "gradient" of the BernoulliSample function.
# grad_output is supposed to be the gradient w.r.t. the output of the forward method.
@staticmethod
def backward(ctx: torch.Any, grad_output: torch.Tensor) -> torch.Tensor: # type: ignore
def backward(ctx: Any, grad_output: torch.Tensor) -> torch.Tensor: # type: ignore
Comment thread
lotif marked this conversation as resolved.
# ctx.saved_tensors is a tuple (of length 1 in this case). Hence the indexing here.
bernoulli_probs = ctx.saved_tensors[0]
return bernoulli_probs * grad_output
Expand Down
Loading