Creating FedBN client and adding test#396
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
==========================================
+ Coverage 76.84% 76.86% +0.01%
==========================================
Files 155 156 +1
Lines 9464 9472 +8
==========================================
+ Hits 7273 7281 +8
Misses 2191 2191 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Feature
Short Description
Really small PR to add in a sanity check layer for FedBN clients. This allows us to ensure that someone wanting to use BN has a bit of a check on their definition of the parameter exchanger. FedBN really only differs from the Basic Client in a single way (uses a layer exchanger with exclusions), but we weren't really enforcing that anywhere and the example was just "doing so properly" so to speak. This PR just adds in a layer where, if the user wants to use a FedBN client, it checks that they have an exchanger of the correct type.
Tests Added
Test that the enforcement fails if the user does not use the right class for parameter exchange.