Skip to content

Creating FedBN client and adding test#396

Merged
emersodb merged 4 commits into
mainfrom
dbe/fedbn_class
Jun 10, 2025
Merged

Creating FedBN client and adding test#396
emersodb merged 4 commits into
mainfrom
dbe/fedbn_class

Conversation

@emersodb

@emersodb emersodb commented Jun 5, 2025

Copy link
Copy Markdown
Collaborator

PR Type

Feature

Short Description

Really small PR to add in a sanity check layer for FedBN clients. This allows us to ensure that someone wanting to use BN has a bit of a check on their definition of the parameter exchanger. FedBN really only differs from the Basic Client in a single way (uses a layer exchanger with exclusions), but we weren't really enforcing that anywhere and the example was just "doing so properly" so to speak. This PR just adds in a layer where, if the user wants to use a FedBN client, it checks that they have an exchanger of the correct type.

Tests Added

Test that the enforcement fails if the user does not use the right class for parameter exchange.

@codecov

codecov Bot commented Jun 5, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.86%. Comparing base (cf69aad) to head (3cdb1ff).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
+ Coverage   76.84%   76.86%   +0.01%     
==========================================
  Files         155      156       +1     
  Lines        9464     9472       +8     
==========================================
+ Hits         7273     7281       +8     
  Misses       2191     2191              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fatemetkl fatemetkl left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@emersodb emersodb merged commit e275a46 into main Jun 10, 2025
10 checks passed
@emersodb emersodb deleted the dbe/fedbn_class branch June 10, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants