[Feature] Add flexible nnunet client and ditto-ify'ed example#411
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #411 +/- ##
==========================================
+ Coverage 80.20% 80.42% +0.21%
==========================================
Files 160 161 +1
Lines 9735 10120 +385
==========================================
+ Hits 7808 8139 +331
- Misses 1927 1981 +54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
07d2d00 to
e5c55d7
Compare
emersodb
left a comment
There was a problem hiding this comment.
Shawn is our expert on NNUnet, so I'll let him do a thorough review of your port to the FlexibleClient base class 🙂.
Left a few comments. There is a thorny one, which is your loosening of the initial_parameters variable to admit an optional. We should probably talk about why that's thorny together. I think there is a way around it, but its a bit of work.
There was a problem hiding this comment.
Looks good! Nice job finally getting this working. My main comment just has to do with an overriden method that doesn't seem like it needs to be. I'll hold off on approving for now as it seems you and David are still sorting out a "thorny" issue regarding the strategy class
e98b6e8 to
b9256b2
Compare
27d7ef4 to
2a8a99b
Compare
scarere
left a comment
There was a problem hiding this comment.
Ok a lot of these comments might be outdated and bit confusing because they were from awhile ago and i just never submitted them by mistake. Will be happy to clarify with follow up comments
70857ec to
304af8e
Compare
… override their benchmarking settings.
PR Type
Feature
Closes: #390
Closes: #364
Short Description
With
FlexibleClientnow merged, we can move on to adding an Nnunet version of this client.Adds
NNunetClientthat subclassesFlexibleClient.examples/nnunet_pfl_examplefor running a ditto-ify'ed version ofFlexibleNNunetClientnnunet_utils.set_nnunet_env_and_reload_modulesChanges
nnunet_utils.set_nnunet_envsupported but deprecated message thrownTests Added
smoke_tests/test_smoke_tests.py::test_ditto_flexible_nnunet_config_2d