Skip to content

Commit 48ad6a0

Browse files
authored
Fixes Firefox places download parsing on third party browsers (#43)
On several third party Firefox based browsers as well as older versions of Firefox the attribute ids 1 and 2 are not used for downloads. Other ids observed include 4,5,6 on Comodo IceDragon and 5,6,7 on Pale Moon. This switches to using the downloads/destinationFileURI, downloads/destinationFileName and downloads/metaData names instead no longer needing to be concerned about what ids are used. This has worked for all Firefox based browsers I have tested it on and I haven't noticed any regressions.
1 parent 6b459bc commit 48ad6a0

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

definitions/Firefox_Bookmarks.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,8 @@ Sources:
6565
dateAdded,
6666
lastModified
6767
FROM moz_annos
68-
WHERE anno_attribute_id IN (1,2)
68+
INNER JOIN moz_anno_attributes ON moz_annos.anno_attribute_id = moz_anno_attributes.id
69+
WHERE moz_anno_attributes.name IN ('downloads/destinationFileURI','downloads/destinationFileName','downloads/metaData')
6970
ORDER BY moz_annos.dateAdded ASC
7071
7172
- name: History

0 commit comments

Comments
 (0)