Create Server.Enrichment.Hashlookup.yaml#569
Open
jCrossM wants to merge 1 commit into
Open
Conversation
|
|
Collaborator
|
It's probably not going to be useful in practice because it sends an API call for each file. You probably need to limit the hashes to check and maybe combine many hashes in the same API call. Do you know if this is a feature of the API? Another possibility is to look up hashes in multiple threads so they are done in parallel. |
Author
|
Yes, wee can send bulk hashes to the API. I will look this way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
If you have some VQL tips to optimize this artifact I'm interested.
Thx!