Consolidate 22 open PRs: DI/testability, perf, SetTimer, path fixes, regex escaping

Squash-merge of branch claude/practical-hopper-DzAhS consolidating all 22 open PRs.

Key changes:
- ahk/Keys.ahk: KeysWindowAPI DI class, optional api param, A_LineFile guard (PRs 76, 94)
- ahk/test_Keys.ahk: new test file with MockKeysAPI (PR 94)
- Lib/v2/WindowManager.ahk: WaitForWindow + GetMonitorAtPos accept api param (PRs 104, 107)
- ahk/test_WindowManager.ahk: WinWait mock + TestWaitForWindow_Timeout (PR 104)
- ahk/GUI/QuotePathIfNeeded_Test.ahk: new tests (PR 79)
- tests/WindowManager_Test.ahk: new GetMonitorAtPos tests (PR 107)
- tests/Other/Lossless_Scaling_Manager_Test.ahk: new ToggleLS tests (PR 92)
- ahk/Black_ops_6/bo6-afk.ahk: SetTimer-based state machines (PR 84)
- ahk/Fullscreen.ahk: fix End hotkey to use ToggleFakeFullscreen (PR 85 over PR 83)
- Lib/v2/AHK_Common.ahk: FindExe empty-name guard, PATH whitespace+quote+slash trim (PRs 91, 95)
- Other/Lossless_Scaling_Manager.ahk: ToggleLS mockable params, A_LineFile guards (PR 92)
- Other/playnite-all.ahk: drop cmd.exe wrapper in PlayBootVideo (PR 102)
- Other/7zEmuPrepper/Final.ahk: remove dead code (PRs 78, 80)
- Other/Citra_per_game_config/v2/CitraConfigHelpers.ahk: escape $ in SetKey (PR 100)
- Other/Citra_per_game_config/v2/CitraConfigHelpers_Test.ahk: $ sign tests (PR 100)
- Other/Citra_per_game_config/tf.ahk: TF_Merge IfExist removal (PR 106)
- Other/Citra_mods/Citra_3DS_Manager.ahk: FileRead+Loop Parse, UpdateConfig cleanup (PRs 98, 88)
- Other/Citra_mods/Citra_Mod_Manager.ahk: FileRead+Loop Parse, FileExist dir check (PRs 99, 81)
- tests/FindExe_Test.ahk: tests 6-11 for path trimming edge cases (PRs 91, 95)

Author: Ven0m0

Lib/v2/AHK_Common.ahk

@@ -57,13 +57,16 @@ InitScript(requireUIA := true, requireAdmin := false, optimize := true) {
 }
 
 FindExe(name, fallbacks := []) {
+    if (name == "")
+        return ""
     if FileExist(name)
         return name
     Loop Parse, EnvGet("PATH"), ";"
     {
-        p := Trim(A_LoopField)
+        p := Trim(A_LoopField, " `t`"")
         if !p
             continue
+        p := RTrim(p, "\/")
         cand := p . "\" . name
         if FileExist(cand)
             return cand

Lib/v2/WindowManager.ahk

@@ -33,26 +33,25 @@ MakeFullscreen(winTitle) {
     MaximizeWindow(winTitle)
 }
 
-WaitForWindow(winTitle, timeout := 30) {
-    try {
-        WinWait(winTitle, , timeout)
-        return true
-    } catch TimeoutError {
-        return false
-    }
+WaitForWindow(winTitle, timeout := 30, api := "") {
+    if !api
+        api := SystemWindowAPI()
+
+    return api.WinWait(winTitle, , timeout) != 0
 }
 
 WaitForProcess(processName, timeout := 30) {
     return ProcessWait(processName, timeout) != 0
 }
 
 GetMonitorAtPos(x, y, api := "") {
-    if !api
-        api := SystemWindowAPI()
-
-    count := api.MonitorGetCount()
+    count := IsObject(api) ? api.MonitorGetCount() : MonitorGetCount()
     Loop count {
-        api.MonitorGet(A_Index, &l, &t, &r, &b)
+        if IsObject(api)
+            api.MonitorGet(A_Index, &l, &t, &r, &b)
+        else
+            MonitorGet(A_Index, &l, &t, &r, &b)
+
         if (l <= x && x <= r && t <= y && y <= b)
             return A_Index
     }
@@ -93,6 +92,7 @@ RestoreWindowBorders(winTitle) {
 }
 
 class SystemWindowAPI {
+    WinWait(winTitle, winText?, timeout?) => WinWait(winTitle, winText?, timeout?)
     WinGetStyle(winTitle) => WinGetStyle(winTitle)
     WinSetStyle(style, winTitle) => WinSetStyle(style, winTitle)
     WinMove(x, y, w, h, winTitle) => WinMove(x, y, w, h, winTitle)

Other/7zEmuPrepper/Final.ahk

@@ -4,7 +4,6 @@
 ; 7zEmuPrepper command builder (for 7zEmuPrepper.ps1)
 ; Fields -> emits a ready-to-run PowerShell command. Includes a Copy button.
 
-sevenZEmuPrepperPath := ""
 sevenZipPath := ""
 emulatorPath := ""
 arguments := ""
@@ -46,15 +45,6 @@ gui.Add("Button", "x340 y430 w80 h23", "Exit").OnEvent("Click", (*) => ExitApp()
 gui.Show("w480 h470")
 return
 
-SelectFileOrDir(btn) {
-    global
-    text := btn.Text
-    if (text = "…") {
-        ; infer based on label order
-        idx := btn.Hwnd
-    }
-}
-
 ; Simplified per-control selection based on Y position
 SelectFileOrDir(btn, *) {
     y := btn.Pos.Y

Other/Citra_mods/Citra_3DS_Manager.ahk

@@ -27,9 +27,10 @@ LoadDestinations(){
   DestMap := {}
   if !FileExist(DestCsv)
     return
-  Loop, Read, %DestCsv%
+  FileRead, csvData, %DestCsv%
+  Loop, Parse, csvData, `n, `r
   {
-    line := Trim(A_LoopReadLine)
+    line := Trim(A_LoopField)
     if (line = "" || !InStr(line, ","))
       continue
     StringSplit, p, line, `,
@@ -56,29 +57,35 @@ ScanMods(){
 ;----------------- Config Helpers -----------------
 UpdateConfig(content, updates){
   remaining := updates.Clone()
+  remCount  := remaining.Count()
 
   ; Pre-allocate buffer for performance.
-  ; content size + estimated size for updates + null terminator
-  VarSetCapacity(newContent, (StrLen(content) + updates.Count() * 100 + 1) * (A_IsUnicode ? 2 : 1))
   newContent := ""
+  VarSetCapacity(newContent, (StrLen(content) + remCount * 100 + 1) * (A_IsUnicode ? 2 : 1))
 
   Loop, Parse, content, `n, `r
   {
     line := A_LoopField
-    pos := InStr(line, "=")
-    if (pos > 1){
-      keyCandidate := RTrim(SubStr(line, 1, pos-1))
-      if (remaining.HasKey(keyCandidate)){
-        val := remaining[keyCandidate]
-        line := keyCandidate "=" val
-        remaining.Delete(keyCandidate)
+    if (remCount > 0){
+      pos := InStr(line, "=")
+      if (pos > 1){
+        keyCandidate := RTrim(SubStr(line, 1, pos-1))
+        if (remaining.HasKey(keyCandidate)){
+          line := keyCandidate "=" remaining[keyCandidate]
+          remaining.Delete(keyCandidate)
+          remCount--
+        }
       }
     }
-    newContent .= line "`n"
+    newContent .= line
+    newContent .= "`n"
   }
 
   for k, v in remaining {
-     newContent .= k "=" v "`n"
+     newContent .= k
+     newContent .= "="
+     newContent .= v
+     newContent .= "`n"
   }
 
   return SubStr(newContent, 1, -1)

Other/Citra_mods/Citra_Mod_Manager.ahk

@@ -16,11 +16,12 @@ root := OneDrive "\Backup\Game\Emul\Citra\nightly-mingw\Mods"
 
 ; Read CSV once and cache destinations in an associative array
 Destinations := {}
-loop Read, % A_ScriptDir "\Destination.csv"
+FileRead, csvContent, % A_ScriptDir "\Destination.csv"
+loop Parse, csvContent, `n, `r
 {
-    if (InStr(A_LoopReadLine, ","))
+    if (InStr(A_LoopField, ","))
     {
-        parts := StrSplit(A_LoopReadLine, ",")
+        parts := StrSplit(A_LoopField, ",")
         if (parts.Length() >= 2)
             Destinations[parts[1]] := parts[2]
     }
@@ -61,12 +62,7 @@ FileActions(Root, Button)
         Fullpath := Zielpfad "\" button.Ziel "\" button.Name
         Checkdir := Zielpfad "\" button.Ziel
         Quellpfad := button.Path
-        dirHasItems := false
-        Loop, Files, %Checkdir%\*, DF       ;Loop through items in dir
-        {
-          dirHasItems := true               ;Mark that we found at least one item
-          Break                             ;Optimization: Break after finding the first item
-        }
+        dirHasItems := FileExist(Checkdir "\*") != ""
         If !dirHasItems                     ;Is directory empty?
         {
           FileCopyDir, %Quellpfad%, %Fullpath%

Other/Citra_per_game_config/tf.ahk

@@ -889,12 +889,11 @@ TF_Merge(FileList, Separator = "`n", FileName = "merged.txt")
      OW=0
      Loop, Parse, FileList, `n, `r
         {
-         Append2File= ; Just make sure it is empty
-         IfExist, %A_LoopField%
+         FileRead, Append2File, %A_LoopField%
+         If not ErrorLevel ; Successfully loaded
             {
-             FileRead, Append2File, %A_LoopField%
-             If not ErrorLevel ; Successfully loaded
-                Output .= Append2File Separator
+            Output .= Append2File
+            Output .= Separator
             }
         }
 

Other/Citra_per_game_config/v2/CitraConfigHelpers.ahk

@@ -18,7 +18,7 @@
 ;   Escaped string safe for use in regex patterns
 ; ============================================================================
 RegExEscape(str) {
-    return RegExReplace(str, "([\\()\[\]{}?*+|^$.])", "\$1")
+    return RegExReplace(str, "([\\()\[\]{}?*+|^$.})", "\\$1")
 }
 
 ; ============================================================================
@@ -36,9 +36,9 @@ RegExEscape(str) {
 ;   Modified configuration content
 ; ============================================================================
 SetKey(content, key, value) {
-    pat := "m)^(" . RegExEscape(key) . ")\s*=.*$"
+    pat := "m)^(" . RegExEscape(key) . ")\\s*=.*$"
     if RegExMatch(content, pat)
-        return RegExReplace(content, pat, "$1=" value, , 1)
+        return RegExReplace(content, pat, "$1=" StrReplace(value, "$", "$$"), , 1)
     else
         return content "`n" key "=" value
 }

Other/Citra_per_game_config/v2/CitraConfigHelpers_Test.ahk

@@ -73,6 +73,22 @@ TestSetKey() {
     content2 := "path\to\file=exists`n"
     result := SetKey(content2, "path\to\file", "updated")
     AssertEqual(InStr(result, "path\to\file=updated") > 0, true, "SetKey updates key with backslashes")
+
+    ; Test 6: Empty value
+    result := SetKey(content, "key1", "")
+    AssertEqual(InStr(result, "key1=") > 0 && InStr(result, "key1=value1") == 0, true, "SetKey handles empty value")
+
+    ; Test 7: Value with literal $ sign
+    result := SetKey(content, "key1", "val$ue")
+    AssertEqual(InStr(result, "key1=val$ue") > 0, true, "SetKey handles value with literal $ sign")
+
+    ; Test 8: Value with literal $1
+    result := SetKey(content, "key2", "val$1ue")
+    AssertEqual(InStr(result, "key2=val$1ue") > 0, true, "SetKey handles value with literal $1")
+
+    ; Test 9: Add new key with $ sign
+    result := SetKey(content, "key4", "new$val")
+    AssertEqual(InStr(result, "key4=new$val") > 0, true, "SetKey adds new key with $ sign")
 }
 
 TestReplaceInFile() {
@@ -116,7 +132,6 @@ TestReplaceInFile() {
     AssertEqual(content, "goodbye world`ngoodbye citra", "ReplaceInFile leaves content unchanged when text not found")
 
     ; Test 5: ReplaceInFile handles try/catch error (SaveConfig fails or LoadConfig fails)
-    ; In this case, we can pass a directory to trigger an error
     testDir := A_ScriptDir . "\test_replace_dir"
     if !DirExist(testDir)
         DirCreate(testDir)

Other/Lossless_Scaling_Manager.ahk

@@ -13,7 +13,9 @@ EnsureAdmin() {
   try Run('*RunAs "' A_AhkPath '" "' A_ScriptFullPath '" ' A_Args.Join(" "))
   ExitApp
 }
-EnsureAdmin()
+if (A_LineFile == A_ScriptFullPath) {
+  EnsureAdmin()
+}
 
 MinimizeLS() {
   try {
@@ -35,23 +37,29 @@ StopLS() {
   try ProcessClose("LosslessScaling.exe")
 }
 
-ToggleLS() {
-  if ProcessExist("LosslessScaling.exe")
-    StopLS()
+ToggleLS(mockProcessExist := "", mockStopLS := "", mockStartLS := "") {
+  fnProcessExist := (mockProcessExist != "") ? mockProcessExist : ProcessExist
+  fnStopLS := (mockStopLS != "") ? mockStopLS : StopLS
+  fnStartLS := (mockStartLS != "") ? mockStartLS : StartLS
+
+  if fnProcessExist("LosslessScaling.exe")
+    fnStopLS()
   else
-    StartLS()
+    fnStartLS()
 }
 
 ; ---------- Dispatch ----------
-cmd := (A_Args.Length ? StrLower(A_Args[1]) : "toggle")
-try {
-  switch cmd {
-    case "start":  StartLS()
-    case "stop", "close": StopLS()
-    case "toggle": ToggleLS()
-    default:
-      MsgBox("Usage: " A_ScriptName " [start|stop|toggle]")
+if (A_LineFile == A_ScriptFullPath) {
+  cmd := (A_Args.Length ? StrLower(A_Args[1]) : "toggle")
+  try {
+    switch cmd {
+      case "start":  StartLS()
+      case "stop", "close": StopLS()
+      case "toggle": ToggleLS()
+      default:
+        MsgBox("Usage: " A_ScriptName " [start|stop|toggle]")
+    }
+  } catch Error as err {
+    MsgBox("Error: " err.Message)
   }
-} catch Error as err {
-  MsgBox("Error: " err.Message)
 }

Other/playnite-all.ahk

@@ -19,8 +19,7 @@ PlayBootVideo() {
     vlcPath := MustGetExe("vlc.exe", ["C:\Program Files\VideoLAN\VLC\vlc.exe"])
     bootVideo := A_ScriptDir . "\BootVideo.mp4"
     vlcArgs := '--fullscreen --video-on-top --play-and-exit --no-video-title -Idummy "' . bootVideo . '"'
-    RunWait('cmd.exe /c START "" "' . vlcPath . '" ' . vlcArgs, , "hide")
-    DllCall("kernel32.dll\Sleep", "UInt", 3000)
+    RunWait('"' . vlcPath . '" ' . vlcArgs, , "hide")
 }
 LaunchPlaynite() {
     playniteExe := MustGetExe(