🧪 Add dependency injection and tests for MustGetExe (#103)

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Author: Ven0m0

.github/workflows/ahk-lint-format-compile.yml

@@ -19,10 +19,22 @@ jobs:
       - uses: actions/checkout@v6
 
       - name: Install AutoHotkey v1.1 (Portable)
-        run: choco install autohotkey.portable --version=1.1.36.01 -y
+        run: |
+          for ($i=0; $i -lt 3; $i++) {
+            choco install autohotkey.portable --version=1.1.36.01 -y
+            if ($LASTEXITCODE -eq 0) { break }
+            Start-Sleep -Seconds 10
+          }
+          if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
         shell: pwsh
       - name: Install AutoHotkey v2
-        run: choco install autohotkey -y
+        run: |
+          for ($i=0; $i -lt 3; $i++) {
+            choco install autohotkey -y
+            if ($LASTEXITCODE -eq 0) { break }
+            Start-Sleep -Seconds 10
+          }
+          if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
         shell: pwsh
       - name: Verify Installations
         run: |

Lib/v2/AHK_Common.ahk

@@ -74,12 +74,20 @@ FindExe(name, fallbacks := []) {
     return ""
 }
 
-MustGetExe(name, fallbacks := []) {
+MustGetExe(name, fallbacks := [], mockMsgBox := "", mockExitApp := "") {
     exe := FindExe(name, fallbacks)
     if exe = ""
     {
-        MsgBox("Required executable not found: " . name . "`nChecked PATH and fallbacks.")
-        ExitApp(1)
+        msg := "Required executable not found: " . name . "`nChecked PATH and fallbacks."
+        if mockMsgBox !== ""
+            mockMsgBox(msg)
+        else
+            MsgBox(msg)
+
+        if mockExitApp !== ""
+            mockExitApp(1)
+        else
+            ExitApp(1)
     }
     return exe
 }

tests/FindExe_Test.ahk

@@ -59,6 +59,26 @@ try {
     EnvSet("PATH", ";;" . mockPath . ";;")
     AssertEqual(testBaseDir . "\PathDir2\tool.exe", FindExe("tool.exe"), "Should handle empty entries in PATH")
 
+    ; MustGetExe Tests
+
+    ; Test 6: MustGetExe success path
+    AssertEqual(directPath, MustGetExe(directPath), "MustGetExe should return path if found")
+
+    ; Test 7: MustGetExe failure path
+    mockState := Map("msgBoxCalled", false, "exitAppCalled", false, "exitCode", "")
+
+    mockMsgBox := (msg) => (mockState["msgBoxCalled"] := true)
+    mockExitApp := (code) => (mockState["exitAppCalled"] := true, mockState["exitCode"] := code)
+
+    ; Attempt to find a non-existent file with no fallbacks
+    try {
+        MustGetExe("definitely_nonexistent.exe", [], mockMsgBox, mockExitApp)
+    }
+
+    AssertEqual(1, mockState["msgBoxCalled"], "MustGetExe should call MsgBox on failure")
+    AssertEqual(1, mockState["exitAppCalled"], "MustGetExe should call ExitApp on failure")
+    AssertEqual(1, mockState["exitCode"], "MustGetExe should exit with code 1 on failure")
+
     ; Final Results
     stdout.WriteLine("---")
     stdout.WriteLine("Tests Passed: " . testsPassed)