FakeNitro: Enable toggling Favorites server#4019
Open
PrinceBunBun981 wants to merge 1 commit intoVendicated:mainfrom
Open
FakeNitro: Enable toggling Favorites server#4019PrinceBunBun981 wants to merge 1 commit intoVendicated:mainfrom
PrinceBunBun981 wants to merge 1 commit intoVendicated:mainfrom
Conversation
If the experiment is active, this'll allow toggling the setting in User Settings > Chat > Show Favorites Server, will also show in the server list.
Contributor
|
I agree this probably will get fixed by changing favorites logic, but I think for now this should work and is acceptable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Discord making changes to the Favorites experiment and planning to release it to Nitro Standard, this patch makes the function
isPremiumExactlyalways return true, enabling both the Show Favorites Server setting in User Settings > Chat and the server appearing in the server list.Currently, you'd need the experiment enabled, but it should hopefully work if they roll things out as they are, since it's just modifying what that function returns, not the actual Favorites logic. However, I wouldn't be surprised if they change how the client handles making sure people without Standard won't be able to access it, lol
Do tell if I shouldn't PR patches for experiments that haven't rolled out yet though