New Plugin: Deterministic User Panning#4039
Draft
regulad wants to merge 2 commits intoVendicated:mainfrom
Draft
Conversation
regulad
changed the title
Author
|
If anybody has experience tinkering with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone. This is my first contribution to this project.
This is a simple plugin which pans the audio of every user to a different place between left and right, creating a simple soundstage where you can pick out voices by position in addition to timbre.
Unfortunately, while the logic for setting the
setLocalPanningis sound, it would appear that Discord removed the support for panning behind the scenes as nothing happens even when runningsetLocalPanningand then confirming it withgetLocalPanning. The panning functionality is documented as an RPC method (https://docs.discord.com/developers/topics/rpc#setuservoicesettings).This PR is left as a draft as I am attempting to patch panning support back into
MediaEngineNative(It lists it as supported, but it doesn't actually work).