fix(showMeYourName): Exclude emojis from gradients#4070
Open
sillyElvy wants to merge 12 commits intoVendicated:devfrom
Open
fix(showMeYourName): Exclude emojis from gradients#4070sillyElvy wants to merge 12 commits intoVendicated:devfrom
sillyElvy wants to merge 12 commits intoVendicated:devfrom
Conversation
…mally please don't kill me for this gruesome regex
thanks satan
Contributor
Author
|
regex is super pretty now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue is, as shown below, that emojis become part of the gradient making them a colored blob without keeping the emoji recognizable
with this fix the plugin uses the same behaviour discord does for emojis in nicknames