Skip to content

fix PermissionsViewer 'View Role Members'#4202

Open
meowpurrpur wants to merge 6 commits into
Vendicated:mainfrom
meowpurrpur:main
Open

fix PermissionsViewer 'View Role Members'#4202
meowpurrpur wants to merge 6 commits into
Vendicated:mainfrom
meowpurrpur:main

Conversation

@meowpurrpur

@meowpurrpur meowpurrpur commented May 7, 2026

Copy link
Copy Markdown

Closes #4192

The “View Role Members” button added by PermissionsViewer relies on the RoleMemberPopout hook implemented by BetterRoleContext. Without the plugin enabled, the popout renders without any members.

This is resolved by implementing the hook used in BetterRoleContext to acquire the RoleMemberPopout component.

@Vendicated

Copy link
Copy Markdown
Owner

I kind of overlooked the fact that BetterRoleContext needs its patch to function...

This is indeed a fix but I'm not sure if I like making BetterRoleContext a dependency of PermissionViewer

@meowpurrpur

Copy link
Copy Markdown
Author

Ah alright, i'll look at fixing it another way

@meowpurrpur

Copy link
Copy Markdown
Author

@Vendicated would the updated fix I made be better than adding it as a dependency? i don't have much experience with plugins and stuff

@RealKai295

Copy link
Copy Markdown

I want this to be pushed yes push mhm 😔

@meowpurrpur

Copy link
Copy Markdown
Author

review pretty please 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [PermissionsViewer] 'View Role Members' Does Nothing

3 participants