fix: solve comments

cuzz-venus · cuzz-venus · commit 68a561bc95f3 · 2026-06-16T14:24:59.000+08:00
diff --git a/.gitignore b/.gitignore
@@ -46,7 +46,3 @@ Thumbs.db
 
 # AI development artifacts
 .ui-develop
-
-# local file
-*.local
-*.local.*
diff --git a/apps/evm/src/libs/translations/translations/en.json b/apps/evm/src/libs/translations/translations/en.json
@@ -1254,14 +1254,14 @@
     "endOfCycle": {
       "days": "Days",
       "deadline": "{{date, MMMM d, yyyy h:mm a}}",
-      "helper": "Stay in the top 500 until <bold>{{deadline}}</bold> to receive Prime rewards during the next cycle. Check the <summaryLink>See last cycle's Prime summary</summaryLink> now to view your ranking and stay competitive.",
+      "helper": "Stay in the top 500 until <bold>{{deadline}}</bold> to receive Prime rewards during the next cycle. <summaryLink>See last cycle's Prime summary</summaryLink>.",
       "helperEnded": "Stay in the top 500 until {{deadline}} to receive Prime rewards during the next cycle.",
       "hours": "Hours",
       "mins": "Mins",
       "sec": "Sec",
       "title": "End of cycle"
     },
-    "tablesRefreshNote": "Refreshed hourly · Last refresh: {{distance}} ago",
+    "tablesRefreshNote": "Refreshed hourly · Last refresh: {{date, distanceToNow}} ago",
     "title": "Prime leaderboard"
   },
   "primeStatusBanner": {
diff --git a/apps/evm/src/libs/translations/translations/ja.json b/apps/evm/src/libs/translations/translations/ja.json
@@ -1254,14 +1254,14 @@
     "endOfCycle": {
       "days": "日",
       "deadline": "{{date, MMMM d, yyyy h:mm a}}",
-      "helper": "<bold>{{deadline}}</bold> まで上位 500 位以内を維持すると、次のサイクルで Prime 報酬を獲得できます。<summaryLink>前回サイクルの Prime サマリーを見る</summaryLink>と、順位を確認して競争を有利に進められます。",
+      "helper": "<bold>{{deadline}}</bold> まで上位 500 位以内を維持すると、次のサイクルで Prime 報酬を獲得できます。<summaryLink>前回サイクルの Prime サマリーを見る</summaryLink>。",
       "helperEnded": "{{deadline}} まで上位 500 位以内を維持すると、次のサイクルで Prime 報酬を獲得できます。",
       "hours": "時間",
       "mins": "分",
       "sec": "秒",
       "title": "サイクル終了"
     },
-    "tablesRefreshNote": "1時間ごとに更新 · 最終更新：{{distance}}前",
+    "tablesRefreshNote": "1時間ごとに更新 · 最終更新：{{date, distanceToNow}}前",
     "title": "Prime リーダーボード"
   },
   "primeStatusBanner": {
diff --git a/apps/evm/src/libs/translations/translations/th.json b/apps/evm/src/libs/translations/translations/th.json
@@ -1254,14 +1254,14 @@
     "endOfCycle": {
       "days": "วัน",
       "deadline": "{{date, MMMM d, yyyy h:mm a}}",
-      "helper": "รักษาอันดับใน 500 อันดับแรกจนถึง <bold>{{deadline}}</bold> เพื่อรับรางวัล Prime ในรอบถัดไป <summaryLink>ดูสรุป Prime ของรอบที่แล้ว</summaryLink> เพื่อดูอันดับของคุณและรักษาความสามารถในการแข่งขัน",
+      "helper": "รักษาอันดับใน 500 อันดับแรกจนถึง <bold>{{deadline}}</bold> เพื่อรับรางวัล Prime ในรอบถัดไป <summaryLink>ดูสรุป Prime ของรอบที่แล้ว</summaryLink>",
       "helperEnded": "รักษาอันดับใน 500 อันดับแรกจนถึง {{deadline}} เพื่อรับรางวัล Prime ในรอบถัดไป",
       "hours": "ชม.",
       "mins": "นาที",
       "sec": "วินาที",
       "title": "สิ้นสุดรอบ"
     },
-    "tablesRefreshNote": "รีเฟรชทุกชั่วโมง · รีเฟรชล่าสุด: {{distance}} ที่แล้ว",
+    "tablesRefreshNote": "รีเฟรชทุกชั่วโมง · รีเฟรชล่าสุด: {{date, distanceToNow}} ที่แล้ว",
     "title": "กระดานผู้นำ Prime"
   },
   "primeStatusBanner": {
diff --git a/apps/evm/src/libs/translations/translations/tr.json b/apps/evm/src/libs/translations/translations/tr.json
@@ -1254,14 +1254,14 @@
     "endOfCycle": {
       "days": "Gün",
       "deadline": "{{date, MMMM d, yyyy h:mm a}}",
-      "helper": "Sonraki döngüde Prime ödülleri kazanmak için <bold>{{deadline}}</bold> tarihine kadar ilk 500 içinde kalın. Sıralamanızı görmek ve rekabette kalmak için <summaryLink>geçen döngünün Prime özetini görüntüleyin</summaryLink>.",
+      "helper": "Sonraki döngüde Prime ödülleri kazanmak için <bold>{{deadline}}</bold> tarihine kadar ilk 500 içinde kalın. <summaryLink>Geçen döngünün Prime özetini görüntüleyin</summaryLink>.",
       "helperEnded": "Sonraki döngüde Prime ödülleri kazanmak için {{deadline}} tarihine kadar ilk 500 içinde kalın.",
       "hours": "Saat",
       "mins": "Dak.",
       "sec": "Sn.",
       "title": "Döngü sonu"
     },
-    "tablesRefreshNote": "Saatlik yenilenir · Son yenileme: {{distance}} önce",
+    "tablesRefreshNote": "Saatlik yenilenir · Son yenileme: {{date, distanceToNow}} önce",
     "title": "Prime lider tablosu"
   },
   "primeStatusBanner": {
diff --git a/apps/evm/src/libs/translations/translations/vi.json b/apps/evm/src/libs/translations/translations/vi.json
@@ -1254,14 +1254,14 @@
     "endOfCycle": {
       "days": "Ngày",
       "deadline": "{{date, MMMM d, yyyy h:mm a}}",
-      "helper": "Giữ vị trí trong top 500 đến <bold>{{deadline}}</bold> để nhận thưởng Prime trong chu kỳ tiếp theo. <summaryLink>Xem tổng kết Prime của chu kỳ trước</summaryLink> để theo dõi thứ hạng và duy trì tính cạnh tranh.",
+      "helper": "Giữ vị trí trong top 500 đến <bold>{{deadline}}</bold> để nhận thưởng Prime trong chu kỳ tiếp theo. <summaryLink>Xem tổng kết Prime của chu kỳ trước</summaryLink>.",
       "helperEnded": "Giữ vị trí trong top 500 đến {{deadline}} để nhận thưởng Prime trong chu kỳ tiếp theo.",
       "hours": "Giờ",
       "mins": "Phút",
       "sec": "Giây",
       "title": "Kết thúc chu kỳ"
     },
-    "tablesRefreshNote": "Làm mới mỗi giờ · Lần làm mới cuối: {{distance}} trước",
+    "tablesRefreshNote": "Làm mới mỗi giờ · Lần làm mới cuối: {{date, distanceToNow}} trước",
     "title": "Bảng xếp hạng Prime"
   },
   "primeStatusBanner": {
diff --git a/apps/evm/src/libs/translations/translations/zh-Hans.json b/apps/evm/src/libs/translations/translations/zh-Hans.json
@@ -1254,14 +1254,14 @@
     "endOfCycle": {
       "days": "天",
       "deadline": "{{date, MMMM d, yyyy h:mm a}}",
-      "helper": "在 <bold>{{deadline}}</bold> 之前保持在前 500 名，即可在下个周期获得 Prime 奖励。<summaryLink>查看上个周期的 Prime 总结</summaryLink>，了解你的排名并保持竞争力。",
+      "helper": "在 <bold>{{deadline}}</bold> 之前保持在前 500 名，即可在下个周期获得 Prime 奖励。<summaryLink>查看上个周期的 Prime 总结</summaryLink>。",
       "helperEnded": "在 {{deadline}} 之前保持在前 500 名，即可在下个周期获得 Prime 奖励。",
       "hours": "时",
       "mins": "分",
       "sec": "秒",
       "title": "周期结束"
     },
-    "tablesRefreshNote": "每小时刷新 · 上次刷新：{{distance}}前",
+    "tablesRefreshNote": "每小时刷新 · 上次刷新：{{date, distanceToNow}}前",
     "title": "Prime 排行榜"
   },
   "primeStatusBanner": {
diff --git a/apps/evm/src/libs/translations/translations/zh-Hant.json b/apps/evm/src/libs/translations/translations/zh-Hant.json
@@ -1254,14 +1254,14 @@
     "endOfCycle": {
       "days": "天",
       "deadline": "{{date, MMMM d, yyyy h:mm a}}",
-      "helper": "在 <bold>{{deadline}}</bold> 之前保持在前 500 名，即可在下個週期獲得 Prime 獎勵。<summaryLink>查看上個週期的 Prime 總結</summaryLink>，了解你的排名並保持競爭力。",
+      "helper": "在 <bold>{{deadline}}</bold> 之前保持在前 500 名，即可在下個週期獲得 Prime 獎勵。<summaryLink>查看上個週期的 Prime 總結</summaryLink>。",
       "helperEnded": "在 {{deadline}} 之前保持在前 500 名，即可在下個週期獲得 Prime 獎勵。",
       "hours": "時",
       "mins": "分",
       "sec": "秒",
       "title": "週期結束"
     },
-    "tablesRefreshNote": "每小時刷新 · 上次刷新：{{distance}}前",
+    "tablesRefreshNote": "每小時刷新 · 上次刷新：{{date, distanceToNow}}前",
     "title": "Prime 排行榜"
   },
   "primeStatusBanner": {
diff --git a/apps/evm/src/pages/PrimeLeaderboard/EndOfCycle/Timer/index.tsx b/apps/evm/src/pages/PrimeLeaderboard/EndOfCycle/Timer/index.tsx
@@ -2,6 +2,8 @@ import { Fragment } from 'react';
 
 import { useTranslation } from 'libs/translations';
 
+import { pad } from './pad';
+
 export interface TimerProps {
   days: number;
   hours: number;
@@ -12,8 +14,6 @@ export interface TimerProps {
 export const Timer: React.FC<TimerProps> = ({ days, hours, minutes, seconds }) => {
   const { t } = useTranslation();
 
-  const pad = (value: number) => String(value).padStart(2, '0');
-
   const segments = [
     { label: t('primeLeaderboard.endOfCycle.days'), value: days },
     { label: t('primeLeaderboard.endOfCycle.hours'), value: hours },
diff --git a/apps/evm/src/pages/PrimeLeaderboard/EndOfCycle/Timer/pad/index.ts b/apps/evm/src/pages/PrimeLeaderboard/EndOfCycle/Timer/pad/index.ts
@@ -0,0 +1 @@
+export const pad = (value: number) => String(value).padStart(2, '0');
diff --git a/apps/evm/src/pages/PrimeLeaderboard/EndOfCycle/__tests__/index.spec.tsx b/apps/evm/src/pages/PrimeLeaderboard/EndOfCycle/__tests__/index.spec.tsx
@@ -13,8 +13,8 @@ describe('pages/PrimeLeaderboard/EndOfCycle', () => {
     expect(screen.getByText("See last cycle's Prime summary")).toBeInTheDocument();
   });
 
-  it('renders the ended state when no end date is provided', () => {
-    renderComponent(<EndOfCycle />);
+  it('renders the ended state for a past end date', () => {
+    renderComponent(<EndOfCycle endDate={new Date(Date.now() - ONE_DAY_MS)} />);
 
     expect(screen.getByText('End of cycle')).toBeInTheDocument();
     expect(screen.queryByText("See last cycle's Prime summary")).not.toBeInTheDocument();
diff --git a/apps/evm/src/pages/PrimeLeaderboard/EndOfCycle/index.tsx b/apps/evm/src/pages/PrimeLeaderboard/EndOfCycle/index.tsx
@@ -7,7 +7,7 @@ import { useTranslation } from 'libs/translations';
 import { Timer } from './Timer';
 
 export interface EndOfCycleProps {
-  endDate?: Date;
+  endDate: Date;
   className?: string;
 }
 
@@ -22,7 +22,7 @@ interface CountdownState {
 export const EndOfCycle: React.FC<EndOfCycleProps> = ({ endDate, className }) => {
   const { t, Trans } = useTranslation();
 
-  const deadline = endDate ? t('primeLeaderboard.endOfCycle.deadline', { date: endDate }) : '';
+  const deadline = t('primeLeaderboard.endOfCycle.deadline', { date: endDate });
 
   const renderCard = ({ days, hours, minutes, seconds, completed }: CountdownState) => (
     <Card
@@ -57,9 +57,5 @@ export const EndOfCycle: React.FC<EndOfCycleProps> = ({ endDate, className }) =>
     </Card>
   );
 
-  if (!endDate) {
-    return renderCard({ days: 0, hours: 0, minutes: 0, seconds: 0, completed: true });
-  }
-
   return <ReactCountdown date={endDate} renderer={renderCard} />;
 };
diff --git a/apps/evm/src/pages/PrimeLeaderboard/index.tsx b/apps/evm/src/pages/PrimeLeaderboard/index.tsx
@@ -1,6 +1,6 @@
-import { endOfMonth } from 'date-fns';
+import { endOfMonth, subHours } from 'date-fns';
 
-import { Card, Page } from 'components';
+import { Card, Page, Spinner } from 'components';
 import { useTranslation } from 'libs/translations';
 
 import { EndOfCycle } from './EndOfCycle';
@@ -15,7 +15,7 @@ import { UserRewardsCard } from './UserRewardsCard';
 const endOfCycleDate = endOfMonth(new Date());
 
 // TODO: use the indexer's last refresh time returned by the API
-const lastRefreshDistance = '6h';
+const lastRefreshedAt = subHours(new Date(), 6);
 
 const PrimeLeaderboard: React.FC = () => {
   const { t } = useTranslation();
@@ -33,10 +33,17 @@ const PrimeLeaderboard: React.FC = () => {
 
       <Hero />
 
-      <EndOfCycle endDate={endOfCycleDate} className="relative mx-auto mt-8 w-full max-w-[467px]" />
+      {endOfCycleDate ? (
+        <EndOfCycle
+          endDate={endOfCycleDate}
+          className="relative mx-auto mt-8 w-full max-w-[467px]"
+        />
+      ) : (
+        <Spinner className="relative mx-auto mt-8" />
+      )}
 
       <p className="relative mt-4 text-right text-b2s text-light-grey">
-        {t('primeLeaderboard.tablesRefreshNote', { distance: lastRefreshDistance })}
+        {t('primeLeaderboard.tablesRefreshNote', { date: lastRefreshedAt })}
       </p>
 
       <div className="relative mt-3 flex flex-col gap-3 lg:flex-row">

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+export const pad = (value: number) => String(value).padStart(2, '0');`