feat: support isolation mode tag#5600
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 3280b2d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR adds an "Isolated" mode tag to the market table asset column and updates the supply asset-warning copy to surface E-mode and isolation-mode context to users.
Confidence Score: 5/5Safe to merge; all changed paths are UI-only and the logic for detecting isolated assets is well-guarded. The core detection logic in No files require special attention beyond the minor design-token nit in Important Files Changed
Reviews (3): Last reviewed commit: "feat: fix tooltip content & market show ..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Author
|
@greptile review again |
Contributor
Coverage Report for ./apps/evm
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
cuzz-venus
force-pushed
the
feat/isolation-optimization
branch
from
b677802 to
d81df1d
Compare
therealemjy
reviewed
May 25, 2026
Comment on lines
+55
to
+70
| if (!isAvailableInCore) { | ||
| let i18nKey: string | undefined; | ||
|
|
||
| if (isAvailableInEMode && isAvailableInIsolation) { | ||
| // t('assetWarning.modeOnly.eModeAndIsolation') | ||
| i18nKey = 'assetWarning.modeOnly.eModeAndIsolation'; | ||
| } else if (isAvailableInEMode) { | ||
| // t('assetWarning.modeOnly.eMode') | ||
| i18nKey = 'assetWarning.modeOnly.eMode'; | ||
| } else if (isAvailableInIsolation) { | ||
| // t('assetWarning.modeOnly.isolation') | ||
| i18nKey = 'assetWarning.modeOnly.isolation'; | ||
| } | ||
|
|
||
| if (!i18nKey) { | ||
| return null; |
Contributor
Author
There was a problem hiding this comment.
addressed, thanks!
| return ( | ||
| <> | ||
| <Trans | ||
| // t('assetWarning.supplyDescription') |
Member
There was a problem hiding this comment.
Unnecessary (the extract command will find this translation key automatically)
Contributor
Author
There was a problem hiding this comment.
addressed, thanks!
|
|
||
| {hasMode && ( | ||
| <Trans | ||
| // t('assetWarning.modeInfoHint') |
Member
There was a problem hiding this comment.
Unnecessary (the extract command will find this translation key automatically)
Contributor
Author
There was a problem hiding this comment.
addressed, thanks!
| <SupplyNotification asset={asset} pool={pool} onShowAllMarkets={handleShowAssets} /> | ||
| ) : ( | ||
| <Trans | ||
| // t('assetWarning.borrowDescription') |
Member
There was a problem hiding this comment.
Unnecessary (the extract command will find this translation key automatically)
Contributor
Author
There was a problem hiding this comment.
addressed, thanks!
| <Trans | ||
| i18nKey={i18nKey} | ||
| values={{ tokenSymbol }} | ||
| components={{ Button: showAllMarketsButton, ModeInfoButton: modeInfoButton }} |
Member
There was a problem hiding this comment.
Since you've given a name to ModeInfoButton, I'd recommend also adding a prefix to Button).
Comment on lines
+59
to
+66
| // t('assetWarning.modeOnly.eModeAndIsolation') | ||
| i18nKey = 'assetWarning.modeOnly.eModeAndIsolation'; | ||
| } else if (isAvailableInEMode) { | ||
| // t('assetWarning.modeOnly.eMode') | ||
| i18nKey = 'assetWarning.modeOnly.eMode'; | ||
| } else if (isAvailableInIsolation) { | ||
| // t('assetWarning.modeOnly.isolation') | ||
| i18nKey = 'assetWarning.modeOnly.isolation'; |
Member
There was a problem hiding this comment.
Just to make sure no dev remove the comments in the future, I'd add a notice like this one before each comment:
// Translation key: do not remove this comment
Contributor
Author
There was a problem hiding this comment.
addressed, thanks!
Comment on lines
+292
to
+298
| "modeInfoHint": "<LineBreak/>Visit the <ModeInfoButton>Mode info</ModeInfoButton> section to explore more available groups.", | ||
| "modeOnly": { | ||
| "eMode": "{{tokenSymbol}} is only available in E-mode. Visit the <ModeInfoButton>Mode info</ModeInfoButton> section to enable the group, or browse other assets in <Button>Show all markets</Button>.", | ||
| "eModeAndIsolation": "{{tokenSymbol}} is only available in E-mode and Isolation mode. Visit the <ModeInfoButton>Mode info</ModeInfoButton> section to enable one of the groups, or browse other assets in <Button>Show all markets</Button>.", | ||
| "isolation": "{{tokenSymbol}} is only available in Isolation mode. Visit the <ModeInfoButton>Mode info</ModeInfoButton> section to enable the group, or browse other assets in <Button>Show all markets</Button>." | ||
| }, | ||
| "supplyDescription": "Supplying {{tokenSymbol}} to the Core Pool lets you borrow tokens from this pool exclusively. <Button>Show all markets</Button>" |
Member
There was a problem hiding this comment.
I know you grabbed the content from the designs, but I have told them multiple times that we shouldn't randomly capitalize words in sentences (AIs typically do that). Also, the sentences "browse other wassets in Show all markets" is quite odd. I suggest the following changes, let me know your thoughts:
Suggested change
| "modeInfoHint": "<LineBreak/>Visit the <ModeInfoButton>Mode info</ModeInfoButton> section to explore more available groups.", | |
| "modeOnly": { | |
| "eMode": "{{tokenSymbol}} is only available in E-mode. Visit the <ModeInfoButton>Mode info</ModeInfoButton> section to enable the group, or browse other assets in <Button>Show all markets</Button>.", | |
| "eModeAndIsolation": "{{tokenSymbol}} is only available in E-mode and Isolation mode. Visit the <ModeInfoButton>Mode info</ModeInfoButton> section to enable one of the groups, or browse other assets in <Button>Show all markets</Button>.", | |
| "isolation": "{{tokenSymbol}} is only available in Isolation mode. Visit the <ModeInfoButton>Mode info</ModeInfoButton> section to enable the group, or browse other assets in <Button>Show all markets</Button>." | |
| }, | |
| "supplyDescription": "Supplying {{tokenSymbol}} to the Core Pool lets you borrow tokens from this pool exclusively. <Button>Show all markets</Button>" | |
| "modeInfoHint": "<LineBreak/>Visit the <ModeInfoButton>mode info</ModeInfoButton> section to explore more available groups.", | |
| "modeOnly": { | |
| "eMode": "{{tokenSymbol}} is only available in E-mode. Visit the <ModeInfoButton>mode info</ModeInfoButton> section to enable the group, or browse <Button>other assets</Button>.", | |
| "eModeAndIsolation": "{{tokenSymbol}} is only available in E-mode and Isolation mode. Visit the <ModeInfoButton>mode info</ModeInfoButton> section to enable one of the groups, or browse <Button>other assets</Button>.", | |
| "isolation": "{{tokenSymbol}} is only available in Isolation mode. Visit the <ModeInfoButton>mode info</ModeInfoButton> section to enable the group, or browse <Button>other assets</Button>." | |
| }, | |
| "supplyDescription": "Supplying {{tokenSymbol}} to the Core Pool lets you borrow tokens from this pool exclusively. <Button>Show all markets</Button>" |
therealemjy
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket(s)
VPD-1201
Changes