Revert "Prevent crashes on extension reload by ensuring signal teardown"

This reverts commit 92e0a04.

Author: 60k41p

stagehand/nodes/instanced_renderer_3d.cpp

@@ -185,44 +185,28 @@ void InstancedRenderer3D::set_prefabs_rendered(const godot::PackedStringArray &p
     update_configuration_warnings();
 }
 
-void InstancedRenderer3D::connect_configuration_change_signals() {
+void InstancedRenderer3D::set_lod_levels(const godot::TypedArray<InstancedRenderer3DLODConfiguration> &p_lod_levels) {
     const godot::Callable warnings_callable = callable_mp(static_cast<godot::Node *>(this), &godot::Node::update_configuration_warnings);
 
     for (int i = 0; i < lod_levels.size(); ++i) {
-        godot::Ref<InstancedRenderer3DLODConfiguration> lod_level = lod_levels[i];
-        if (lod_level.is_valid() && !lod_level->is_connected("changed", warnings_callable)) {
-            lod_level->connect("changed", warnings_callable);
+        godot::Ref<InstancedRenderer3DLODConfiguration> previous_lod_level = lod_levels[i];
+        if (previous_lod_level.is_valid() && previous_lod_level->is_connected("changed", warnings_callable)) {
+            previous_lod_level->disconnect("changed", warnings_callable);
         }
     }
-}
 
-void InstancedRenderer3D::disconnect_configuration_change_signals() {
-    const godot::Callable warnings_callable = callable_mp(static_cast<godot::Node *>(this), &godot::Node::update_configuration_warnings);
+    lod_levels = p_lod_levels;
 
     for (int i = 0; i < lod_levels.size(); ++i) {
         godot::Ref<InstancedRenderer3DLODConfiguration> lod_level = lod_levels[i];
-        if (lod_level.is_valid() && lod_level->is_connected("changed", warnings_callable)) {
-            lod_level->disconnect("changed", warnings_callable);
+        if (lod_level.is_valid() && !lod_level->is_connected("changed", warnings_callable)) {
+            lod_level->connect("changed", warnings_callable);
         }
     }
-}
-
-void InstancedRenderer3D::set_lod_levels(const godot::TypedArray<InstancedRenderer3DLODConfiguration> &p_lod_levels) {
-    disconnect_configuration_change_signals();
-
-    lod_levels = p_lod_levels;
-
-    connect_configuration_change_signals();
 
     update_configuration_warnings();
 }
 
-void InstancedRenderer3D::_notification(int p_what) {
-    if (p_what == godot::Node::NOTIFICATION_EXIT_TREE || p_what == godot::Object::NOTIFICATION_PREDELETE) {
-        disconnect_configuration_change_signals();
-    }
-}
-
 godot::PackedStringArray InstancedRenderer3D::_get_configuration_warnings() const {
     godot::PackedStringArray warnings;
 

stagehand/nodes/instanced_renderer_3d.h

@@ -92,12 +92,8 @@ class InstancedRenderer3D : public godot::Node3D {
 
   protected:
     static void _bind_methods();
-    void _notification(int p_what);
 
   private:
-    void connect_configuration_change_signals();
-    void disconnect_configuration_change_signals();
-
     godot::PackedStringArray prefabs_rendered;
     godot::TypedArray<InstancedRenderer3DLODConfiguration> lod_levels;
     godot::Ref<godot::Material> material;