Skip to content

Allow 0 instances to launch #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimonCropp merged 3 commits into from
Oct 10, 2025
Merged

Allow 0 instances to launch #653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16daece
Allow 0 instances to launch
SimonCropp Oct 10, 2025
003472a
Merge branch 'main' into Allow-0-instances-to-launch
SimonCropp Oct 10, 2025
32c7b3d
Merge branch 'main' into Allow-0-instances-to-launch
SimonCropp Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/DiffEngine/Guard.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
static class Guard
{
public static void AgainstNegativeAndZero(int value, string argumentName)
public static void AgainstNegative(int value, string argumentName)
{
if (value <= 0)
if (value < 0)
{
throw new ArgumentOutOfRangeException(argumentName);
}
Expand Down
4 changes: 2 additions & 2 deletions src/DiffEngine/MaxInstance.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@ static int GetMaxInstances() =>

public static void SetForAppDomain(int value)
{
Guard.AgainstNegativeAndZero(value, nameof(value));
Guard.AgainstNegative(value, nameof(value));
appDomainMaxInstancesToLaunch = value;
ResetCapturedValue();
}

public static void SetForUser(int value)
{
Guard.AgainstNegativeAndZero(value, nameof(value));
Guard.AgainstNegative(value, nameof(value));
EnvironmentHelper.Set("DiffEngine_MaxInstances", value.ToString());
ResetCapturedValue();
}
Expand Down
4 changes: 2 additions & 2 deletions src/DiffEngineTray/Settings/OptionsForm.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<Project>
<PropertyGroup>
<NoWarn>CS1591;CS0649;NU1608;NU1109</NoWarn>
<Version>16.7.1</Version>
<Version>16.7.2</Version>
<AssemblyVersion>1.0.0</AssemblyVersion>
<PackageTags>Testing, Snapshot, Diff, Compare</PackageTags>
<Description>Launches diff tools based on file extensions. Designed to be consumed by snapshot testing libraries.</Description>
Expand Down